Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webhook type from int to string #13664

Merged
merged 8 commits into from
Dec 8, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 21, 2020

As title.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2020
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 21, 2020
@6543 6543 added this to the 1.14.0 milestone Nov 21, 2020
@6543 6543 mentioned this pull request Dec 2, 2020
@6543
Copy link
Member

6543 commented Dec 2, 2020

@lunny if you merge lunny#11 and resolve migration conflict it should be done

@lunny lunny force-pushed the lunny/change_hook_task_type branch from 4beebbf to a890031 Compare December 2, 2020 08:57
@lunny
Copy link
Member Author

lunny commented Dec 2, 2020

@6543 done.

@lunny lunny force-pushed the lunny/change_hook_task_type branch from a890031 to d78d218 Compare December 2, 2020 14:00
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2020
@codecov-io
Copy link

Codecov Report

Merging #13664 (cd94b0d) into master (18712ea) will decrease coverage by 0.11%.
The diff coverage is 28.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13664      +/-   ##
==========================================
- Coverage   42.25%   42.14%   -0.12%     
==========================================
  Files         708      709       +1     
  Lines       77127    77118       -9     
==========================================
- Hits        32591    32500      -91     
- Misses      39169    39273     +104     
+ Partials     5367     5345      -22     
Impacted Files Coverage Δ
models/migrations/migrations.go 2.44% <ø> (ø)
models/migrations/v161.go 0.00% <0.00%> (ø)
models/webhook.go 68.97% <ø> (+0.81%) ⬆️
modules/convert/convert.go 74.89% <0.00%> (ø)
routers/api/v1/repo/hook.go 26.41% <ø> (ø)
routers/api/v1/utils/hook.go 0.00% <0.00%> (ø)
routers/init.go 50.40% <ø> (ø)
routers/repo/webhook.go 1.04% <0.00%> (ø)
services/webhook/deliver.go 46.87% <0.00%> (ø)
services/webhook/dingtalk.go 6.81% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18712ea...cd94b0d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 8, 2020
@6543
Copy link
Member

6543 commented Dec 8, 2020

🚀

@6543 6543 merged commit 42354df into go-gitea:master Dec 8, 2020
@lunny lunny deleted the lunny/change_hook_task_type branch December 8, 2020 12:16
@jolheiser
Copy link
Member

This migration needs to be updated to convert the webhook model as well.
I'm not sure if more code needs to be changed as well from a cursory glance.

HookTaskType HookTaskType

@bobemoe bobemoe mentioned this pull request Dec 8, 2020
6 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants