Fix whitespace rendering in diff #13415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
force-pushed
the
fixindent
branch
2 times, most recently
from
35b3e8a to
87b70bd
Compare
- Introduce new .code-inner class that sets the CSS attributes on rendered code lines like view,blame and diff. - Rename .wrap class to .word-break to reflect what it actually does - Remove .raw which was only used on webhook page - Set white-space: pre-wrap except on blame where it can break the layout Fixes: go-gitea#13406
lafriks
approved these changes
Nov 3, 2020
GiteaBot
added
the
lgtm/need 1
mrsdizzie
approved these changes
Nov 4, 2020
GiteaBot
added
lgtm/done
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Nov 13, 2020
We can't wrap code in blame because it's essentially two tables side-by-side which will misalign them when one line gets larger. Fixes: go-gitea#13540 Regressed by: go-gitea#13415
techknowlogick
added a commit
that referenced
this pull request
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.code-innerclass that sets the CSS attributes on rendered code lines like view, blame and diff..wrapclass to.word-breakto reflect what it actually does.pre-wraphelper, currently unused.rawwhich was only used on webhook pagewhite-space: pre-wrapexcept on blame where it can break the layoutFixes: #13406