Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migrated pulls to pull request task queue #13331

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Add migrated pulls to pull request task queue #13331

merged 3 commits into from
Oct 27, 2020

Conversation

zeripath
Copy link
Contributor

Fix #13321

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Add migrated pulls to pull request task queue
c808fb4 
Fix go-gitea#13321

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Oct 27, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 27, 2020
@6543 6543 added the topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them label Oct 27, 2020
@zeripath
Improve error reports
c5e0611 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 27, 2020
@codecov-io
Copy link

Codecov Report

Merging #13331 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13331      +/-   ##
==========================================
- Coverage   42.13%   42.11%   -0.03%     
==========================================
  Files         689      689              
  Lines       75845    75846       +1     
==========================================
- Hits        31956    31940      -16     
- Misses      38658    38673      +15     
- Partials     5231     5233       +2
Impacted Files Coverage Δ
modules/migrations/gitea_downloader.go 0.93% <0.00%> (ø)
modules/migrations/gitea_uploader.go 6.72% <0.00%> (-0.02%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.92%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c2c521...af80db4. Read the comment docs.

@techknowlogick techknowlogick merged commit 7dfb2fc into go-gitea:master Oct 27, 2020
@techknowlogick
Copy link
Member

Please send backport :)

@zeripath zeripath deleted the fix-13321-add-migrated-prs-to-testqueues branch October 27, 2020 21:39
zeripath added a commit to zeripath/gitea that referenced this pull request Oct 27, 2020
@zeripath @techknowlogick
Add migrated pulls to pull request task queue (go-gitea#13331)
3fe9552 
* Add migrated pulls to pull request task queue

Fix go-gitea#13321

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Improve error reports

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@zeripath zeripath mentioned this pull request Oct 27, 2020
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Oct 27, 2020
@zeripath
Copy link
Contributor Author

It could probably be backported to v1.12 too...

zeripath added a commit to zeripath/gitea that referenced this pull request Oct 27, 2020
@zeripath
Add migrated pulls to pull request task queue (go-gitea#13331)
65ebb22 
Backport go-gitea#13331

Fix go-gitea#13321

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Oct 27, 2020
Merged
techknowlogick added a commit that referenced this pull request Oct 27, 2020
@zeripath @techknowlogick
Add migrated pulls to pull request task queue (#13331) (#13334)
adfe13f 
* Add migrated pulls to pull request task queue

Fix #13321

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Improve error reports

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick pushed a commit that referenced this pull request Oct 27, 2020
@zeripath
Add migrated pulls to pull request task queue (#13331) (#13335)
e6723ef 
Backport #13331

Fix #13321

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Oct 28, 2020
Closed
6 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

migration: pull requests show broken but they dont
6 participants
@zeripath @codecov-io @techknowlogick @mrsdizzie @6543 @GiteaBot