Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PAM from auth dropdown when unavailable #13276

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Remove PAM from auth dropdown when unavailable #13276

merged 1 commit into from
Oct 23, 2020

Conversation

jolheiser
Copy link
Member

Related to #13257

This will at least remove the option when PAM is not supported.

@jolheiser
Remove PAM from auth dropdown when unavailable
f0eed7a 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added this to the 1.14.0 milestone Oct 23, 2020
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality and removed type/miscellaneous labels Oct 23, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2020
lunny
lunny approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a quick fix, I think this is enough.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2020
@zeripath zeripath merged commit 21d6213 into go-gitea:master Oct 23, 2020
@zeripath
Copy link
Contributor

please send backport

@jolheiser jolheiser deleted the pam branch October 23, 2020 14:08
jolheiser added a commit to jolheiser/gitea that referenced this pull request Oct 23, 2020
@jolheiser
Remove PAM from auth dropdown when unavailable (go-gitea#13276)
dd1f3f8 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser mentioned this pull request Oct 23, 2020
Merged
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Oct 23, 2020
techknowlogick pushed a commit that referenced this pull request Oct 23, 2020
@jolheiser
Remove PAM from auth dropdown when unavailable (#13276) (#13281)
074f7ab 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jolheiser @zeripath @lunny @techknowlogick @GiteaBot