Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mirror IsEmpty status on synchronize #13185

Merged

Conversation

zeripath
Copy link
Contributor

Fix #9630
Fix #13183

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#9630
Fix go-gitea#13183

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Oct 17, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 25, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #13185 into master will decrease coverage by 0.03%.
The diff coverage is 4.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13185      +/-   ##
==========================================
- Coverage   42.10%   42.07%   -0.04%     
==========================================
  Files         689      689              
  Lines       75721    75764      +43     
==========================================
- Hits        31881    31874       -7     
- Misses      38610    38658      +48     
- Partials     5230     5232       +2     
Impacted Files Coverage Δ
services/mirror/mirror.go 16.17% <4.44%> (-2.35%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.92%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
modules/queue/workerpool.go 62.04% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d130cd1...0370066. Read the comment docs.

@lunny lunny merged commit e2740b3 into go-gitea:master Oct 25, 2020
@zeripath zeripath deleted the fix-9630-13183-set-is-empty-on-mirrored-repos branch October 25, 2020 08:29
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 27, 2020
…s-stored-in-email-address-table

* origin/master:
  [UI] Hide consecutive additions and removals of the same label (go-gitea#13315)
  [skip ci] Updated translations via Crowdin
  Fix send mail (go-gitea#13312)
  [skip ci] Updated translations via Crowdin
  Deny wrong pull (go-gitea#13308)
  Group Label Changed Comments in timeline (go-gitea#13304)
  [skip ci] Updated translations via Crowdin
  Attempt to handle unready PR in tests (go-gitea#13305)
  go-gitea#12897 - add mastodon provider (go-gitea#13293)
  [skip ci] Updated translations via Crowdin
  Fix Storage mapping (go-gitea#13297)
  Update Mirror IsEmpty status on synchronize (go-gitea#13185)
  Fix bug isEnd detection on getIssues/getPullRequests (go-gitea#13299)
  systemd service: Add commented PATH environment option for Git prefix (go-gitea#13170)
  Sendmail command (go-gitea#13079)
  Various UI and arc-green fixes (go-gitea#13291)
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated of { Mirror of an uninitialized repository #9630 } Mirror of an uninitialized repository
5 participants