Skip to content

Fix error create comment on outdated file #13041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2020
Merged

Fix error create comment on outdated file #13041

merged 4 commits into from
Oct 6, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Oct 5, 2020

fix #12658

@zeripath thanks for the hint ;)

@6543 6543 added this to the 1.13.0 milestone Oct 5, 2020
@6543 6543 mentioned this pull request Oct 5, 2020
Closed
7 tasks
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #13041 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13041      +/-   ##
==========================================
- Coverage   42.61%   42.61%   -0.01%     
==========================================
  Files         672      672              
  Lines       73785    73785              
==========================================
- Hits        31441    31440       -1     
+ Misses      37259    37251       -8     
- Partials     5085     5094       +9
Impacted Files Coverage Δ
services/pull/review.go 47.74% <0.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
models/notification.go 65.76% <0.00%> (-0.91%) ⬇️
models/error.go 34.34% <0.00%> (-0.85%) ⬇️
modules/notification/mail/mail.go 34.48% <0.00%> (ø)
modules/git/repo.go 46.70% <0.00%> (+0.50%) ⬆️
modules/log/event.go 58.49% <0.00%> (+0.94%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e76dd...f2d873b. Read the comment docs.

@techknowlogick techknowlogick merged commit df4bbcd into go-gitea:master Oct 6, 2020
@techknowlogick techknowlogick deleted the fix-error-create-commento-on-outdated-file_12658 branch October 6, 2020 00:19
@techknowlogick
Copy link
Member

techknowlogick commented Oct 6, 2020

@6543 please send backport :)

6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 6, 2020
@6543 @techknowlogick
Fix error create comment on outdated file (go-gitea#13041)
a768cb6 
* FIX

* more specific

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@6543 6543 mentioned this pull request Oct 6, 2020
Merged
@6543
Copy link
Member Author

6543 commented Oct 6, 2020

backport -> #13042

@6543 6543 added the backport/done All backports for this PR have been created label Oct 6, 2020
lunny pushed a commit that referenced this pull request Oct 6, 2020
@6543 @techknowlogick
Fix error create comment on outdated file (#13041) (#13042)
40a7660 
* FIX

* more specific

Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

Error when trying to reply to a comment in an outdated file

5 participants

@6543 @codecov-commenter @techknowlogick @zeripath @GiteaBot