Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update revive lint to latest commit #12921

Merged
merged 3 commits into from
Sep 22, 2020
Merged

update revive lint to latest commit #12921

merged 3 commits into from
Sep 22, 2020

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added topic/code-linting dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 22, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 22, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020 •
edited
Loading

Codecov Report

Merging #12921 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12921      +/-   ##
==========================================
- Coverage   43.09%   43.08%   -0.01%     
==========================================
  Files         658      658              
  Lines       72454    72454              
==========================================
- Hits        31221    31216       -5     
- Misses      36178    36181       +3     
- Partials     5055     5057       +2
Impacted Files Coverage Δ
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e8bda...f2d8c7b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 22, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 22, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 22, 2020
@lafriks lafriks merged commit 1c3278c into go-gitea:master Sep 22, 2020
@techknowlogick techknowlogick deleted the update-revive branch September 22, 2020 17:14
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@techknowlogick @codecov-commenter @lafriks @jolheiser @GiteaBot