Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git open close bug #12834

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Fix git open close bug #12834

merged 1 commit into from
Sep 14, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 14, 2020

Fix a bug that git pointer may not be close.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 14, 2020
@zeripath zeripath added this to the 1.13.0 milestone Sep 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12834 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12834      +/-   ##
==========================================
+ Coverage   43.17%   43.21%   +0.04%     
==========================================
  Files         654      654              
  Lines       72218    72218              
==========================================
+ Hits        31177    31208      +31     
+ Misses      35989    35966      -23     
+ Partials     5052     5044       -8     
Impacted Files Coverage Δ
services/pull/pull.go 42.03% <100.00%> (ø)
models/error.go 35.66% <0.00%> (+0.85%) ⬆️
models/repo_list.go 79.46% <0.00%> (+0.89%) ⬆️
models/notification.go 67.04% <0.00%> (+0.91%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
services/pull/check.go 50.00% <0.00%> (+2.30%) ⬆️
modules/notification/ui/ui.go 83.33% <0.00%> (+2.77%) ⬆️
modules/notification/mail/mail.go 37.93% <0.00%> (+3.44%) ⬆️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️
modules/indexer/stats/db.go 69.56% <0.00%> (+8.69%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1a633...53251f2. Read the comment docs.

@zeripath zeripath merged commit 642c3c2 into go-gitea:master Sep 14, 2020
@lunny lunny deleted the lunny/fix_pull_bug branch September 14, 2020 23:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants