Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Primary Key to Topic and RepoTopic tables #12639

Merged
merged 5 commits into from
Sep 10, 2020
Merged

Add Primary Key to Topic and RepoTopic tables #12639

merged 5 commits into from
Sep 10, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 29, 2020 •
edited
Loading

Add a primary key to Topic and RepoTopic tables

Fix #8920

Should also fix #12061

Signed-off-by: Andrew Thornton art27@cantab.net

@silverwind

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 29, 2020
@zeripath

This comment has been minimized.

Sign in to view
@zeripath zeripath force-pushed the fix-8920-add-primary-key-to-repo_topic branch 6 times, most recently from 654e16b to 42ed95d Compare September 6, 2020 12:27
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2020 •
edited
Loading

Codecov Report

Merging #12639 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12639      +/-   ##
==========================================
- Coverage   43.22%   43.19%   -0.04%     
==========================================
  Files         650      651       +1     
  Lines       72101    72118      +17     
==========================================
- Hits        31165    31148      -17     
- Misses      35889    35920      +31     
- Partials     5047     5050       +3
Impacted Files Coverage Δ
models/migrations/migrations.go 2.46% <ø> (ø)
models/migrations/v150.go 0.00% <0.00%> (ø)
models/topic.go 66.87% <ø> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
services/mirror/mirror.go 18.58% <0.00%> (-1.36%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-1.02%) ⬇️
modules/log/event.go 56.60% <0.00%> (-0.95%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8dad3...b7b015a. Read the comment docs.

@zeripath
Add Primary Key to Topic and RepoTopic
0288ae8 
Add a primary key to Topic and RepoTopic tables

Fix go-gitea#8920

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath force-pushed the fix-8920-add-primary-key-to-repo_topic branch from 42ed95d to 0288ae8 Compare September 6, 2020 21:54
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 9, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2020
@6543
Copy link
Member

6543 commented Sep 10, 2020

seems resonable

@6543 6543 added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Sep 10, 2020
@6543
Copy link
Member

6543 commented Sep 10, 2020 •
edited
Loading

for release: leave a note to BACKUP DB

@zeripath zeripath added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Sep 10, 2020
@zeripath

This comment has been minimized.

Sign in to view
techknowlogick
techknowlogick previously requested changes Sep 10, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding blocking review so it isn't accidentally merged.

@zeripath
Copy link
Contributor Author

Panic over it was right.

@zeripath zeripath removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Sep 10, 2020
@zeripath zeripath merged commit 4728934 into go-gitea:master Sep 10, 2020
@zeripath zeripath deleted the fix-8920-add-primary-key-to-repo_topic branch September 10, 2020 19:45
@zeripath zeripath mentioned this pull request Sep 13, 2020
Closed
5 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Upgrade from 1.11.6 to 1.12.1 fails (MySQL 8 Innodb cluster) Add primary key to repo_topic table
8 participants
@zeripath @silverwind @codecov-commenter @6543 @techknowlogick @lafriks @GiteaBot @lunny