Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merge section in dark theme #12086

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Fix merge section in dark theme #12086

merged 3 commits into from
Jun 30, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jun 29, 2020

Before:

image

After:

image

@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.12 labels Jun 29, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 29, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 29, 2020
@lafriks
Copy link
Member Author

lafriks commented Jun 29, 2020

@silverwind these values was there already so I would not like to change them (I just moved them into one group). Only actual changes are added > .merge-section.no-header:(before|after)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 30, 2020
@lafriks
Copy link
Member Author

lafriks commented Jun 30, 2020

🚀

@lafriks lafriks merged commit 8f48913 into go-gitea:master Jun 30, 2020
@lafriks lafriks deleted the fix/theme_dark_merge_section branch June 30, 2020 23:03
@zeripath
Copy link
Contributor

zeripath commented Jul 1, 2020

Please send backport

lafriks added a commit to lafriks-fork/gitea that referenced this pull request Jul 1, 2020
@lafriks
Fix merge section in dark theme (go-gitea#12086)
032d787 
* Fix merge section in dark theme

* Fix lint
@lafriks lafriks mentioned this pull request Jul 1, 2020
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Jul 1, 2020
zeripath pushed a commit that referenced this pull request Jul 2, 2020
@lafriks
Fix merge section in dark theme (#12086) (#12109)
47b1fc5 
Backport #12086

* Fix merge section in dark theme

* Fix lint
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@lafriks
Fix merge section in dark theme (go-gitea#12086)
0e553e3 
* Fix merge section in dark theme

* Fix lint
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @zeripath @silverwind @mrsdizzie @GiteaBot