Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rough draft of Gitea to Gitea migration. #11698

Closed
wants to merge 8 commits into from
Closed

Rough draft of Gitea to Gitea migration. #11698

wants to merge 8 commits into from

Conversation

j-be
Copy link

@j-be j-be commented May 30, 2020

Add a GiteaDownloader implemenatation for Gitea, allowing Gitea -> Gitea Migrations.

[ ] Find out how to get or default missing fields
[ ] Work on unit tests

refs #8380

@j-be
Rough draft of Gitea to Gitea migration.
64ce7d0 
TODOs:

* Find out how to get or default missing fields
* Work on unit tests

refs go-gitea#8380

Signed-off-by: Juri Berlanda <juriberlanda@hotmail.com>
@6543 6543 mentioned this pull request May 30, 2020
Open
24 tasks
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 31, 2020
@6543
Copy link
Member

6543 commented May 31, 2020 •
edited
Loading

IsLocked property I would set to false if I cant get the info - however for v1.13 we will have this info soon :)
#11708

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2020
j-be added 4 commits June 6, 2020 12:06
@j-be
[Bugfix] Correctly map Review.State.
8e300ed 
Signed-off-by: Juri Berlanda <juriberlanda@hotmail.com>
@j-be
[UnitTest] Swap out lunny's ID.
9d4a395 
Telling from the response on go-gitea#11705 this is expected.

Signed-off-by: Juri Berlanda <juriberlanda@hotmail.com>
@j-be
[UnitTest] Use "mrsdizzie(github)" where applicable.
14c3805 
Telling from the response on go-gitea#11705 this is expected.

Signed-off-by: Juri Berlanda <juriberlanda@hotmail.com>
@j-be
[UnitTest] Revert readability changes.
7c5f0c1 
Signed-off-by: Juri Berlanda <juriberlanda@hotmail.com>
@j-be
Copy link
Author

j-be commented Jun 6, 2020 •
edited
Loading

Ok, seems like I'm making progress. But I found another property I'm missing: base.PulRequest.OriginalNumber. I see it is used in gitlab.go, but not in github.go. @6543 shall I just hardcode it to 0?

@6543
Copy link
Member

6543 commented Jun 7, 2020

@j-be just ignore OriginalNumber - as github do

j-be added 2 commits June 15, 2020 18:55
@j-be
[UnitTest] Adpat test to newly migrated repo.
e38195e 
Signed-off-by: Juri Berlanda <juriberlanda@hotmail.com>
@j-be
[Bugfix] Hardcode OriginalNumber to 0.
ba7f0b6 
Signed-off-by: Juri Berlanda <juriberlanda@hotmail.com>
@j-be @6543
Ignore OriginalNumber instead of hardcoding it to 0
086efe3 
Co-authored-by: 6543 <6543@obermui.de>
@j-be
Copy link
Author

j-be commented Jun 15, 2020

Done. What do you think about line 503 currentReviewComments = make([]*base.ReviewComment, 0)? Does that make any sense? I'm fairly new to Go and usually do Java, where you better use empty lists instead of null. Does that apply to Go, too?

@6543
Copy link
Member

6543 commented Jun 15, 2020

If you itterate throu a null list nothing will hapen ...

@lunny
Copy link
Member

lunny commented Jun 16, 2020

@j-be that's not efficent and we need a refactor but I think that's not the business of this PR.

@stale
Copy link

stale bot commented Aug 15, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 15, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 15, 2020
@stale stale bot removed the issue/stale label Aug 15, 2020
@6543
Copy link
Member

6543 commented Aug 30, 2020

what's the matter?

@6543 6543 mentioned this pull request Aug 31, 2020
Merged
12 tasks
@6543
Copy link
Member

6543 commented Aug 31, 2020 •
edited
Loading

@j-be sorry that I have created a similar pr -> #12657

hope you dont mid :)
I would be happy if you could test 12657 and report issues, have code suggestions, ... :)

still a BIG THANKS to the work you have done so far - it was quit the same result as I got ;)

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 left review comments

Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-be @6543 @lunny @GiteaBot