Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hide activity option #11353

Merged
merged 11 commits into from
Jun 5, 2020
Merged

Add hide activity option #11353

merged 11 commits into from
Jun 5, 2020

Conversation

l-jonas
Copy link
Contributor

@l-jonas l-jonas commented May 9, 2020

This closes #7927

I was not able to setup drone, so I did not test according to https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md#testing-redux

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2020
@6543

This comment has been minimized.

Sign in to view
6543
6543 requested changes May 10, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

models/action.go Show resolved Hide resolved
models/action.go Show resolved Hide resolved
@l-jonas
Copy link
Contributor Author

l-jonas commented May 10, 2020

Do I still need to run make fmt? I think it would format the code, but I made changes according to the linter messages and the CI accepts it now.

The make fmt if it does what I think would be a good info for the Readme or the contribution guide. Should I open a pull request for that?

@6543
Copy link
Member

6543 commented May 10, 2020

Do I still need to run make fmt? I think it would format the code, but I made changes according to the linter messages and the CI accepts it now.

The make fmt if it does what I think would be a good info for the Readme or the contribution guide. Should I open a pull request for that?

sorry my tests somehow meesed up - now it works as it should so forget/resolve the suggestions

@6543
Copy link
Member

6543 commented May 10, 2020 •
edited
Loading

but if we speak about tests, it would be nice to add Tests for this

6543
6543 reviewed May 10, 2020
View reviewed changes
options/locale/locale_en-US.ini Outdated
@@ -381,6 +381,7 @@ follow = Follow
unfollow = Unfollow
heatmap.loading = Loading Heatmap…
user_bio = Biography
disabled_public_activity = This user has disabled the public visibility of the activity. Only the user itself and admins can see it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
disabled_public_activity = This user has disabled the public visibility of the activity. Only the user itself and admins can see it.
disabled_public_activity = This user has disabled the public visibility of the activity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a normal user dont need the hint ...

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 12, 2020
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jun 5, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jun 5, 2020
techknowlogick
techknowlogick approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR :)

I hope you don't mind that I've resolved the conflicts.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 5, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit aa3c0f8 into go-gitea:master Jun 5, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@l-jonas @techknowlogick
Add hide activity option (go-gitea#11353)
32bfe50 
* Add hide activity option

This closes go-gitea#7927

* Adjust for linter

* Adjust for linter

* Add tests

* Remove info that admins can view the activity

* Adjust new tests for linter

* Rename v139.go to v140.go

* Rename v140.go to v141.go

* properly indent

* gofmt

Co-authored-by: Jonas Lochmann <git@inkompetenz.org>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@6543 6543 added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 6, 2020
@6543
Copy link
Member

6543 commented Sep 6, 2020

Labled as feature to take more atraction to this option - it would go lost in the huge changelog
And this is something people activly should decide

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

"Activities" tab and the logging for it is bad for the privacy - should be optional
4 participants
@l-jonas @6543 @techknowlogick @GiteaBot