-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scrollbar issues in dropdowns #10897
Conversation
ea0b78d
to
e883ac5
Compare
Codecov Report
@@ Coverage Diff @@
## master #10897 +/- ##
==========================================
+ Coverage 43.59% 43.62% +0.02%
==========================================
Files 597 597
Lines 83923 83923
==========================================
+ Hits 36590 36612 +22
+ Misses 42820 42801 -19
+ Partials 4513 4510 -3
Continue to review full report at Codecov.
|
Issue is that text can expand even wider when localized. I can try some tweaks to get the english version on two lines. Not sure I like how that "tip" is done in general, it's only on this one label dropdown and not on others. I guess we could also opt to just remove it, or maybe move it to a shared template. |
Could the dropdown just have a fixed width/size like on Github regardless of label text length? I think the tip text is the worst part (and I don't really like how its done either) but also just having the same drop down be different sizes in each place doesn't seem great either but perhaps thats just a preference |
Yeah I guess it should be possible to always expand to the tip width and only ellipsis the actual labels. Will try later. |
e883ac5
to
b5eb359
Compare
Ping LG-TM |
See discussion in #10835. @CirnoT: Please confirm this works.
Regarding the help text, I decided to just let it wrap:
(Yes, that border is too bright for in arc-green, but that is for another time)