Skip to content

Conversation

silverwind
Copy link
Member

See discussion in #10835. @CirnoT: Please confirm this works.

Regarding the help text, I decided to just let it wrap:

image

(Yes, that border is too bright for in arc-green, but that is for another time)

@codecov-io
Copy link

codecov-io commented Mar 30, 2020

Codecov Report

Merging #10897 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10897      +/-   ##
==========================================
+ Coverage   43.59%   43.62%   +0.02%     
==========================================
  Files         597      597              
  Lines       83923    83923              
==========================================
+ Hits        36590    36612      +22     
+ Misses      42820    42801      -19     
+ Partials     4513     4510       -3     
Impacted Files Coverage Δ
routers/repo/view.go 36.82% <0.00%> (+0.67%) ⬆️
modules/git/repo.go 48.11% <0.00%> (+0.83%) ⬆️
models/unit.go 44.44% <0.00%> (+2.46%) ⬆️
modules/git/command.go 89.56% <0.00%> (+2.60%) ⬆️
services/pull/check.go 53.04% <0.00%> (+3.04%) ⬆️
modules/git/utils.go 70.14% <0.00%> (+4.47%) ⬆️
modules/indexer/stats/db.go 59.37% <0.00%> (+9.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c97c0...72873a8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 30, 2020
@mrsdizzie
Copy link
Member

I think it is strange the menu changes size depending on label size. Short labels make the alt + click text look particularly bad spread across 3 lines

Screen Shot 2020-03-30 at 7 13 58 PM

If I make a label with a longer name it looks like the screenshot in the description which is 'good enough'
Screen Shot 2020-03-30 at 7 17 38 PM

Then it expands a bit further with a longer name to the maximum size:

Screen Shot 2020-03-30 at 7 18 56 PM

Kind of feel it just just be the same size always (like on Github) and perhaps that size should be enough to put the click + enter text on one line.

@silverwind
Copy link
Member Author

silverwind commented Mar 31, 2020

Issue is that text can expand even wider when localized. I can try some tweaks to get the english version on two lines.

Not sure I like how that "tip" is done in general, it's only on this one label dropdown and not on others. I guess we could also opt to just remove it, or maybe move it to a shared template.

@mrsdizzie
Copy link
Member

mrsdizzie commented Mar 31, 2020

Could the dropdown just have a fixed width/size like on Github regardless of label text length? I think the tip text is the worst part (and I don't really like how its done either) but also just having the same drop down be different sizes in each place doesn't seem great either but perhaps thats just a preference

@silverwind
Copy link
Member Author

Yeah I guess it should be possible to always expand to the tip width and only ellipsis the actual labels. Will try later.

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Mar 31, 2020
@silverwind
Copy link
Member Author

Updated to remove wrapping:

image

image

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 2, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit 6cf71ee into go-gitea:master Apr 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants