Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index code and stats only for non-empty repositories #10251

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Feb 12, 2020

Optimizes to not add empty repositories to indexing queue

Also switch language stats calculation queue to unique queue as there is no point to recalculate stats for same repo multiple times

Fixes #10246

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Feb 12, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 12, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 12, 2020
@guillep2k
Copy link
Member

Unit test fail seems related.

@lafriks
Copy link
Member Author

lafriks commented Feb 12, 2020

Yeah, that repo probably have is_empty set, will fix

@lafriks lafriks force-pushed the fix/index_empty_repo branch 3 times, most recently from 8e02028 to 836f25d Compare February 14, 2020 11:57
Fix test and switch to unique queue

Fix MySQL support when deleting old statistics
@lafriks
Copy link
Member Author

lafriks commented Feb 14, 2020

Make it work

@6543
Copy link
Member

6543 commented Feb 14, 2020

think it is ready now ;)

@sapk sapk merged commit a1d796f into go-gitea:master Feb 14, 2020
@lafriks lafriks deleted the fix/index_empty_repo branch February 14, 2020 12:50
@mqudsi mqudsi mentioned this pull request Feb 14, 2020
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal server Error
6 participants