-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache last commit when pushing for big repository #10109
Conversation
How many commits a repo can be considered big? |
@bagasme there is a config, default is 1000 commits. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
6b4f173
to
98bb979
Compare
0900cc9
to
5c18d97
Compare
Codecov Report
@@ Coverage Diff @@
## master #10109 +/- ##
==========================================
- Coverage 42.62% 42.58% -0.04%
==========================================
Files 672 673 +1
Lines 73785 73855 +70
==========================================
+ Hits 31448 31450 +2
- Misses 37247 37296 +49
- Partials 5090 5109 +19
Continue to review full report at Codecov.
|
@lunny good idear, we only should take care the easy jobs done while pushing should be first (trigger webhooks, calc commit count cache, ..) and the slowest tasks should be add the end |
It needs more refactor here. I will send other PRs. |
1537ed9
to
a1bff86
Compare
CI Failed |
28d02bb
to
06bfd67
Compare
Codecov Report
@@ Coverage Diff @@
## master #10109 +/- ##
==========================================
+ Coverage 42.52% 42.59% +0.06%
==========================================
Files 672 673 +1
Lines 73788 73858 +70
==========================================
+ Hits 31381 31460 +79
+ Misses 37337 37291 -46
- Partials 5070 5107 +37
Continue to review full report at Codecov.
|
This PR will cache the last commit ids for the home page of big repositories entries when a new commit pushed. Then when you visit the home page first time after a new commit pushed, it should be still fast enough.
Still WIP, wait for a queue since it may spent many times.Blocked by #10133