Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore repositories at try.gitea.io #945

Closed
1 task done
ea2973929 opened this issue Feb 15, 2017 · 9 comments
Closed
1 task done

Explore repositories at try.gitea.io #945

ea2973929 opened this issue Feb 15, 2017 · 9 comments
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP type/bug
Milestone

Comments

@ea2973929
Copy link

ea2973929 commented Feb 15, 2017

Description

How to reproduce

  1. Surf to https://try.gitea.io/explore/repos (I tried chrome and IE)

Expected
2. Some sort of demo page of gitea with repositories

Actual
2. Text error message: template: explore/repo_list:5:200: executing "explore/repo_list" at <.Owner.Name>: can't evaluate field Name in type *models.User

Extra comment: "Because first impressions last"

@arkraft
Copy link

arkraft commented Feb 15, 2017

I tried to reproduce it, but it worked fine for me. I was logged in at the time. After reading the models.User i logged out and tried it again, then this error appeared. So i think you try to show something only the logged in user has and this is why it fails.

@lunny lunny added this to the 1.1.0 milestone Feb 15, 2017
@lunny lunny added the type/bug label Feb 15, 2017
@ea2973929
Copy link
Author

Yes, that might very well be the problem. But this is try.gitea.io, where people go to test your software - should it really be a requirement to create a user for that? For comparison https://try.gogs.io/explore/repos works fine without a user.

If you want to require a user you should clearly write some message about this so that a new user knows what to do. Another approach might be to create a demo user for people to use.

@arkraft
Copy link

arkraft commented Feb 15, 2017

I am totally with you on this one. I also think it should work without an account for public projects. All i wanted was to add some more info to the issue as it could help find the problem faster. Sorry if that was not clear enough.

@Bwko
Copy link
Member

Bwko commented Feb 15, 2017

@ea2973929 Unfortunately #940 introduced this bug, @appleboy could you take a look at this?

@tboerger
Copy link
Member

Yep, confirmed that template: explore/repo_list:5:200: executing "explore/repo_list" at <.Owner.Name>: can't evaluate field Name in type *models.User pops up if you try to explore as an anoymous user. Works if you are logged in,

@xsteadfastx
Copy link

same for me on my installation.

@lunny lunny added the issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP label Feb 15, 2017
@lunny
Copy link
Member

lunny commented Feb 15, 2017

@ea2973929 @arkraft @xsteadfastx please confirm this has been fixed via #946

@ea2973929
Copy link
Author

Works for me. I'm not sure what process you have around this. Should I close it as the creator of the issue?

@lunny
Copy link
Member

lunny commented Feb 15, 2017

Please close this.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP type/bug
Projects
None yet
Development

No branches or pull requests

6 participants