Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Commit Graph: pagination sometimes drop last #8798

Closed
6543 opened this issue Nov 2, 2019 · 6 comments · Fixed by #8843
Closed

[Bug] Commit Graph: pagination sometimes drop last #8798

6543 opened this issue Nov 2, 2019 · 6 comments · Fixed by #8843
Labels
Milestone

Comments

@6543
Copy link
Member

6543 commented Nov 2, 2019

repo wich has this problem: https://gitea.com/gitnex/GitNex/graph

"Last" go to https://gitea.com/gitnex/GitNex/graph?page=3
but in realety it is https://gitea.com/gitnex/GitNex/graph?page=4

so affected versions are: current, 1.10?

@lunny lunny added the type/bug label Nov 3, 2019
@jaqra
Copy link
Contributor

jaqra commented Nov 4, 2019

There is 249 commits.
gitea.com shows 100 commit in each page
Can not be 4 pages.

You can see older commits if it did not start from new repository

@6543
Copy link
Member Author

6543 commented Nov 4, 2019

@jaqra you mean gitea takes the number of commits on default branch to calculate the pagesbwichvare needed?

@jaqra
Copy link
Contributor

jaqra commented Nov 4, 2019

Here is the code to get commit count

commitsCount, err := ctx.Repo.GetCommitsCount()

@6543
Copy link
Member Author

6543 commented Nov 4, 2019

note: pagination was added on #8360

@6543
Copy link
Member Author

6543 commented Nov 4, 2019

@jaqra I don't look deep into this particular code jet ...
this is a note wich I/someone can pic up to fix :)

but you got the problem or shuld i describe it better?

@jaqra
Copy link
Contributor

jaqra commented Nov 4, 2019

@6543 i did

@lafriks lafriks modified the milestones: 1.10.0, 1.11.0 Nov 5, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants