Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some messages without line feed and disable page preview in Telegram Webhook #6682

Open
InExtremaRes opened this issue Apr 19, 2019 · 11 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@InExtremaRes
Copy link

InExtremaRes commented Apr 19, 2019

  • Gitea version (or commit ref): b9d1fb6
  • Operating system: Docker
    (rest is irrelevant)

Description

First of all thank you @techknowlogick for #4227. I found some issues and suggestion for the message.

As you can see here

image

when someone comments an issue the bot message doesn't have a new line before the content. Same with comments for a PR. I haven't tested every message to see if this happens elsewhere.

EDIT:
PR #6719 fixes the page preview of the messages (description below) but the line feed in some messages (description above) is still missing.


Also in Telegram, by default a message sent that includes a link will put a preview of the web, a little header and description. I think for the main purpose users want this feature (notifications of events) it is just noise. You can see what I mean here:

image

The method sendMessage in telegram bot API includes a parameter disable_web_page_preview that could be set to false. I think this should be false by default, maybe with an option to enable it.

@InExtremaRes InExtremaRes changed the title Issues and improvement for Telegram webhook Issues with messages and change of page preview in Telegram Webhook Apr 19, 2019
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Apr 19, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 19, 2019
@techknowlogick
Copy link
Member

@InExtremaRes I've just sent a PR to disable previews, as you are right it'll be the same everytime and will just take up unnecessary space.

Please check if #6683 works for you.

@lafriks
Copy link
Member

lafriks commented Apr 25, 2019

Should be fixed by #6719 if not please reopen

@lafriks lafriks closed this as completed Apr 25, 2019
@InExtremaRes
Copy link
Author

@lafriks In fact, as you can see in the comments of #6683, #6719 only fixes the page preview but no the line feeds missing. I can reopen and edit the issue to reflect that fact, or should I open a new issue instead?

@lafriks lafriks reopened this Apr 25, 2019
@lafriks
Copy link
Member

lafriks commented Apr 25, 2019

Please update description what still needs to be done

@InExtremaRes InExtremaRes changed the title Issues with messages and change of page preview in Telegram Webhook Some messages without line feed and disable page preview in Telegram Webhook Apr 27, 2019
@InExtremaRes
Copy link
Author

I edited de issue but I am not sure it is enough. Feel free to edit the title or the content to help to track the issue better.

@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.x.x Jun 25, 2019
@stale
Copy link

stale bot commented Aug 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 24, 2019
@Mikaela
Copy link
Contributor

Mikaela commented Aug 24, 2019

Does this issue include the issue and code previews being a lot more unhelpful than at GitHub?

Screenshot from 2019-08-24 12-55-10

Screenshot from 2019-08-24 12-56-41

as opposed to

Screenshot from 2019-08-24 12-59-15

@stale stale bot removed the issue/stale label Aug 24, 2019
@stale
Copy link

stale bot commented Oct 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Oct 23, 2019
@Mikaela
Copy link
Contributor

Mikaela commented Oct 27, 2019

I am able to reproduce my previous comment of which beimng this issue was never confirmed?

@stale stale bot removed the issue/stale label Oct 27, 2019
@stale
Copy link

stale bot commented Dec 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Dec 26, 2019
@Mikaela
Copy link
Contributor

Mikaela commented Dec 27, 2019

I am still able to reproduce, however the Gitea instance is outdated which cannot be helped at the moment and I think next time I will just open a new issue as my previous comment leave it unclear if this is even my issue.

@stale stale bot removed the issue/stale label Dec 27, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Dec 27, 2019
@lunny lunny removed this from the 1.x.x milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants