-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some messages without line feed and disable page preview in Telegram Webhook #6682
Comments
@InExtremaRes I've just sent a PR to disable previews, as you are right it'll be the same everytime and will just take up unnecessary space. Please check if #6683 works for you. |
Should be fixed by #6719 if not please reopen |
Please update description what still needs to be done |
I edited de issue but I am not sure it is enough. Feel free to edit the title or the content to help to track the issue better. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
I am able to reproduce my previous comment of which beimng this issue was never confirmed? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
I am still able to reproduce, however the Gitea instance is outdated which cannot be helped at the moment and I think next time I will just open a new issue as my previous comment leave it unclear if this is even my issue. |
(rest is irrelevant)
Description
First of all thank you @techknowlogick for #4227. I found some issues and suggestion for the message.
As you can see here
when someone comments an issue the bot message doesn't have a new line before the content. Same with comments for a PR. I haven't tested every message to see if this happens elsewhere.
EDIT:
PR #6719 fixes the page preview of the messages (description below) but the line feed in some messages (description above) is still missing.
Also in Telegram, by default a message sent that includes a link will put a preview of the web, a little header and description. I think for the main purpose users want this feature (notifications of events) it is just noise. You can see what I mean here:
The method sendMessage in telegram bot API includes a parameter
disable_web_page_preview
that could be set tofalse
. I think this should befalse
by default, maybe with an option to enable it.The text was updated successfully, but these errors were encountered: