Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] - Add successfull build on branch protection #6665

Closed
1 of 3 tasks
zopanix opened this issue Apr 17, 2019 · 3 comments
Closed
1 of 3 tasks

[feature] - Add successfull build on branch protection #6665

zopanix opened this issue Apr 17, 2019 · 3 comments
Labels
issue/duplicate The issue has already been reported.

Comments

@zopanix
Copy link

zopanix commented Apr 17, 2019

  • Gitea version (or commit ref): N/A
  • Git version: N/A
  • Operating system: N/A
  • Database (use [x]): N/A
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:
    N/A

Description

As a user, I want the possibility to force successful build on a pull request before merging is allowed.

Ideally, when creating a branch protection, I would like to have an additional checkbox called something like:
Enable Successful Build Check
As description, I would put: Enforce successful build from CI on last commit

As a result, if the last build on a commit is successful, gitea SHOULD allow merging if all other requirements are met, if the build fails, it MUST not be possible to merge the current pull request even if other requirements are met.

@zopanix
Copy link
Author

zopanix commented Apr 17, 2019

FYI: I looked up for a similar issue, but did not find one.
FYI: Bitbucket and gitlab have similar features. I don't know for github

@lunny lunny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 17, 2019
@lunny
Copy link
Member

lunny commented Apr 17, 2019

I think you mean #996 (comment)

@lunny lunny added issue/duplicate The issue has already been reported. and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 17, 2019
@lunny
Copy link
Member

lunny commented Apr 17, 2019

duplicated with #3588

@lunny lunny closed this as completed Apr 17, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Development

No branches or pull requests

2 participants