Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors with swagger on MacOS when running generate-swagger #6468

Closed
richmahn opened this issue Mar 29, 2019 · 0 comments
Closed

Errors with swagger on MacOS when running generate-swagger #6468

richmahn opened this issue Mar 29, 2019 · 0 comments
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Comments

@richmahn
Copy link
Contributor

On MacOS with current master branch of Gitea, if you run "make generate-swagger" you get two problems:

  1. basePath doesn't include {{AppSubUrl}} due to MacOS sed not supporting \s without the -E arg
  2. An EOL marker which doesn't exist if you run this on Linux

This causes the build to fail since drone will have AppSubUrl and no EOL.
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 30, 2019
richmahn added a commit to richmahn/gitea that referenced this issue Mar 30, 2019
@richmahn
Fies go-gitea#6468 - Uses space match and adds newline for all sed fl…
5e2778d 
…avors
@richmahn richmahn mentioned this issue Mar 30, 2019
Merged
lunny pushed a commit that referenced this issue Apr 1, 2019
@richmahn @lunny
Fies #6468 - Uses space match and adds newline for all sed flavors (#…
4e3ce71 
…6473)
@lunny lunny closed this as completed Apr 1, 2019
richmahn added a commit to richmahn/gitea that referenced this issue Apr 11, 2019
@richmahn
Fies go-gitea#6468 - Uses space match and adds newline for all sed fl…
1a78b56 
…avors (go-gitea#6473)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lunny @richmahn