Error 500 on comment creation via API, with sudo

[jlecour]

• Gitea version (or commit ref): 1.7.0
• Git version: 2.20.1
• Operating system: Deban 9.6
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

I've been using the API to import projects and issues from Redmine/Gitolite to Gitea (it will be open sourced soon).
For a few days I've been using a Gitea instance with a version < 1.7 and it seemed to work really well. I could create issues and comments on repositories, with or without the Sudo header.
It seems that after the 1.7 upgrade I can't use Sudo anymore.
My request fail if I add the HTTP header. I get the same error with the query string parameter.

Examples :

# this one works
curl -v -X POST "https://my-gitea/api/v1/repos/jlecour/tests-redmine-to-gitea/issues/1/comments" -H "accept: application/json" -H "Authorization: token XXX" -H "Content-Type: application/json" -d "{ \"body\": \"comment body\"}"

# this one doesn't work (error 500)
curl -v -X POST "https://my-gitea/api/v1/repos/jlecour/tests-redmine-to-gitea/issues/1/comments" -H "accept: application/json" -H "Authorization: token XXX" -H "Content-Type: application/json" -d "{ \"body\": \"comment body\"}" -H "Sudo: other_user"

Obviously other_user exists and is a collaborator on the repository with Write permission.

In the logs, I only get SQL logs with a failed transaction (ROLLBACK). I've executed each request manually against my database and I get no error, so I guess the faulty request is not logged.

I'm not sure if it's a bug or if I did something wrong.
Is there a way to have more information about the error ?

[jlecour]

I've tried this on try.gitea.org but I can't get to use sudo since I'm not an administrator.

[jlecour]

Another strange fact : I can create issues with Sudo (and the same user, on the same repository), but it fails for comments

[zeripath]

Oo that's interesting... Just tried this on master on my local machine.
I can get a 500 if I fail to log in correctly:

[Macaron] 2019-01-27 21:26:23: Started POST /api/v1/repos/administrator/private-with-collaborator/issues/1/comments for 127.0.0.1
[Macaron] PANIC: runtime error: invalid memory address or nil pointer dereference
/usr/lib/go-1.10/src/runtime/panic.go:502 (0x4388f8)
	gopanic: reflectcall(nil, unsafe.Pointer(d.fn), deferArgs(d), uint32(d.siz), uint32(d.siz))
/usr/lib/go-1.10/src/runtime/panic.go:63 (0x43796d)
	panicmem: panic(memoryError)
/usr/lib/go-1.10/src/runtime/signal_unix.go:388 (0x44e879)
	sigpanic: panicmem()
/home/andrew/go/src/code.gitea.io/gitea/routers/api/v1/api.go:88 (0x12a48a2)
	sudo.func1: if ctx.User.IsAdmin {
...

It's de-referencing null because ctx.User isn't actually set anymore.

Nasty. I don't understand how the tests didn't pick this up.

I've put in a PR to fix this.

[zeripath]

OK, I think I've spotted a different bug, because I wasn't actually properly logging in... So I was getting a null pointer - which is bad enough to require a patch in itself...

[zeripath]

I'm not able to completely replicate your issue on master. Let me check on 1.7.0

[jlecour]

Is there a special mode I can run my instance with to help you debug this ?

[zeripath]

Hmm... I can't replicate with a valid token. I can get a 500 if the token is invalid though and I've just put a PR in for that. Are you sure that your token is correct?

[zeripath]

Is there something special about that issue?

[zeripath]

I guess you aren't getting the above nil dereference error?

[jlecour]

As far as I can tell, my token is working.
I've been using it to create/delete repositories and issues (with Sudo), add collaborators to a repository…
I just can't post a comment with Sudo :/

[zeripath]

If you're getting a ROLLBACK then something is causing a conflict in the database - which is very odd.

[jlecour]

It's working perfectly with 1.6.3 but not with 1.7.0.

[zeripath]

I suspect its something to do with my fixing of deadlocks patches. There's a cascade of actions that come after the creation of an issue comment. I wonder if one of them isn't working within the session...