Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: "Hide a comment" on Pull Requests and Issues #5262

Open
BhaaLseN opened this issue Nov 3, 2018 · 6 comments
Open

Feature request: "Hide a comment" on Pull Requests and Issues #5262

BhaaLseN opened this issue Nov 3, 2018 · 6 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/moderation features for moderating spam, abuse, ... type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@BhaaLseN
Copy link

BhaaLseN commented Nov 3, 2018

I was happy to see Gitea had a "Review" feature on Pull Requests similar to GitHub when I was trialling it as replacement for our current hosting, but I'm kinda-of missing the "Hide a comment" feature.

Our main use-case for this would be hiding both PR comments and Code comments that no longer apply (either as "Resolved" or "Outdated"), but it wouldn't hurt to include other options for a more complete experience (such as "Off-topic", "Spam" or "Abuse" for example; but need not limited to those reasons).

We got an external issue tracker, but I'm certain it would also make sense with the built-in tracker to apply to Issues.

Comments would be displayed similar to how GitHub handles it, allowing a reader to expand them if needed:
hidden-comment

@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Nov 3, 2018
@stale
Copy link

stale bot commented Jan 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 4, 2019
@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 5, 2019
@stale stale bot removed the issue/stale label Jan 5, 2019
@6543
Copy link
Member

6543 commented Oct 31, 2020

Comment already has a ResolveDoerID field.

We just have to add a ResolveReason witch could be a int (enum) or varchar if answers can be customized ...

TODOs:

  • extend struct [Go]
  • add action (similar to edit) for hide/unhide [Go]
  • update template to get menue and hide if set [HTML]
  • add smal migration based on struct update [ Go]

@6543 6543 added the good first issue Likely to be an easy fix label Oct 31, 2020
@radiohertz
Copy link

hey @6543, can i have a knock at this?

@6543
Copy link
Member

6543 commented Feb 3, 2021

@segfult sure go on ! (ps: target will be v1.15.0 then so dont rush :) )

@6543 6543 added the topic/moderation features for moderating spam, abuse, ... label Apr 7, 2021
@6543 6543 added this to the 1.16.0 milestone Aug 29, 2021
@lunny lunny modified the milestones: 1.16.0, 1.17.0 Nov 9, 2021
@jpjamipark
Copy link

jpjamipark commented Dec 3, 2021

Hi @6543 , I'd like to work on this issue.

Before I get started though, it looks like currently only PR comments are resolve-able, and issue comments are not. Would it cause problems to also make issue comments hide-able/resolve-able?

@6543
Copy link
Member

6543 commented Dec 3, 2021

yes this is a feature request for issue and pull, its about the "normal comments" :)

and you can follow the hits I describe above to get the job done :)

@lunny lunny modified the milestones: 1.17.0, 1.18.0 May 16, 2022
@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 20, 2022
@lunny lunny removed this from the 1.19.0 milestone Jan 31, 2023
@wxiaoguang wxiaoguang removed the good first issue Likely to be an easy fix label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/moderation features for moderating spam, abuse, ... type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

7 participants