Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please return arc-green theme or add a "dimmed" version of the current dark theme, v1.22 dark contrast is unbearable #31308

Open
yurikus opened this issue Jun 10, 2024 · 14 comments
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea issue/workaround it is or has a workaround topic/ui Change the appearance of the Gitea UI

Comments

@yurikus
Copy link

yurikus commented Jun 10, 2024

Description

v1.22 changed the colors of the dark theme. The new background is almost black and new contrast creates serious eye strain. Please return and support the arc-green theme.

EDIT: If supporting arc-green is not an option as mentioned below by silverwind, please add a "dimmed" version of the current dark theme, with contrast on par with the arc-green of v1.21.

Screenshots

image
image

Gitea Version

1.22

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Firefox 126

@yurikus yurikus added topic/ui Change the appearance of the Gitea UI type/bug labels Jun 10, 2024
@yurikus yurikus changed the title Please return arc-green them, v1.22 dark contrast is unberable Please return arc-green theme, v1.22 dark contrast is unberable Jun 10, 2024
@silverwind
Copy link
Member

I don't think we'll be going back to green primary, but a new low-contrast dark theme could be supported, similar to GitHub's "Dark dimmed".

@yurikus
Copy link
Author

yurikus commented Jun 10, 2024

Dimmed version would be fine, presently it's unusable for me without dark reader. Using it though has some visual glitches:

Milestones page is half-colored

image

@yurikus yurikus changed the title Please return arc-green theme, v1.22 dark contrast is unberable Please return arc-green theme, v1.22 dark contrast is unbearable Jun 10, 2024
@yurikus yurikus changed the title Please return arc-green theme, v1.22 dark contrast is unbearable Please return arc-green theme or add a "dimmed" version of the current dark theme, v1.22 dark contrast is unbearable Jun 10, 2024
@techknowlogick
Copy link
Member

In case others arrive at this thread, some history around this change, is that the increased contrast was to improve accessibility. Although, a dimmed version is likely possible, as long as it isn't the only option (so folks can choose the option that works the best for them).

@yurikus
Copy link
Author

yurikus commented Jun 10, 2024

a dimmed version is likely possible, as long as it isn't the only option

Let's start with at least one dimmed option as presently there's none and UX worsened.

@silverwind
Copy link
Member

Other users do appreciate the increased contrast, but I guess you can never make it right for everyone.

Also I think #30160 is a dependency if we want to keep our sanity while writing additional themes.

@silverwind
Copy link
Member

silverwind commented Jun 11, 2024

Maybe we can actually lighten the backgrounds in dark theme by like 6-12 bits in each color channel. Contrast is still good enough and even tiny changes in dark colors make a big visual difference.

Introducing another dark theme is too problematic imho because in auto theme we can only have one dark theme.

@zc-devs
Copy link

zc-devs commented Jun 15, 2024

For return arc-green theme alone, you can put theme-arc-green.css in GITEA_CUSTOM/... directory. Works like a charm for now.
Customizing the look of Gitea.

@lunny lunny added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea issue/workaround it is or has a workaround and removed type/bug labels Jun 15, 2024
@yurikus
Copy link
Author

yurikus commented Jun 15, 2024

For return arc-green theme alone, you can put theme-arc-green.css in GITEA_CUSTOM/... directory. Works like a charm for now. Customizing the look of Gitea.

A short-lived workaround, given that theme is out of support. Thank you regardless.

@silverwind
Copy link
Member

For return arc-green theme alone, you can put theme-arc-green.css in GITEA_CUSTOM/... directory. Works like a charm for now. Customizing the look of Gitea.

A short-lived workaround, given that theme is out of support. Thank you regardless.

Yes, it may still mostly work for 1.22, but eventually it's bound to break when CSS color variables are added or renamed.

@lsd-techno
Copy link

Here is a temporary workaround for the current version 1.22.1. This includes all variables implemented in the latest theme:

https://github.com/lsd-techno/gitea-theme

@FrostKiwi
Copy link

Here is a temporary workaround for the current version 1.22.1. This includes all variables implemented in the latest theme:

https://github.com/lsd-techno/gitea-theme

Love the arc-green colors.
Unfortunately, using this breaks all Syntax Highlighting.
Broken in Markdown, Broken in the file views 😭

@lsd-techno
Copy link

lsd-techno commented Jul 10, 2024

Here is a temporary workaround for the current version 1.22.1. This includes all variables implemented in the latest theme:
https://github.com/lsd-techno/gitea-theme

Love the arc-green colors. Unfortunately, using this breaks all Syntax Highlighting. Broken in Markdown, Broken in the file views 😭

Thanks for pointing out, code markup looks much pretty now, but can't see file views problem.
1720627731582
View code files looks good too

@hermannoffen
Copy link

I'd like to hint to the fact that by changing the color from green to blue, we threw the corporate design under the bus. Should've changed the logo color as well then.

@QrackEE
Copy link

QrackEE commented Sep 29, 2024

I'd like to hint to the fact that by changing the color from green to blue, we threw the corporate design under the bus. Should've changed the logo color as well then.

Agreed - I loved the green-dominant consistent with logotype in grey-ish dark theme; I wish had noticed and raised the voice when PR for theme change was open... Hope our 'cup of tee' doesn't go the blue way, as I much prefer green tea ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea issue/workaround it is or has a workaround topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

9 participants