Notifications not marked as read upon returning with the browser back button

[svarlamov]

• Gitea version (or commit ref): 033ad9a

Description

When I click on a notification from /notifications from the "Unread" tab to go to an issue. When I use the browser back button to go to the notifications list "Unread" tab, the notification is still showing there as unread. When I subsequently refresh the /notifications page, it has been moved to the "Read" tab. This seems to be caused by improper browser caching of the /notifications page when you use the browser back button. I'm using Google Chrome Version 62.0.3202.94 (Official Build) (64-bit).

[andreynering]

A HTTP header to disable cache would do the trick.

https://stackoverflow.com/a/2068407

[svarlamov]

@andreynering I'm not too familiar with the best practices here, but I think that this makes sense for pages that load high-churn data, ie., issue pages, PRs, etc.

[raucao]

By the way, the icon should disappear from the same issue as soon as there aren't any notifications left. The issue is not with the back button, but that the notifications should be marked as read and no red icon should appear before rendering the issue page for the last issue that was notified about.

Ideally, there would be sth like server-sent events (SSE) to also update the icon on previously opened issue pages, for when you open a bunch of issues in tabs. But that's more of a new feature than fixing this bug I guess.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.