Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed bindata optionally #30

Closed
tboerger opened this issue Nov 3, 2016 · 4 comments
Closed

Embed bindata optionally #30

tboerger opened this issue Nov 3, 2016 · 4 comments
Assignees
@tboerger
Labels
type/enhancement An improvement of existing functionality
Milestone
1.0.0

Comments

@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

I would like to embed the bindata optionally based on a build tag, since we are running a Go application I really love the feature to server everything from the single file.
@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 3, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Nov 4, 2016

Cannot up-vote this issue enough, this is killing my dev-speed because I have to recompile all the time for things that aren't even being compiled 😒

@bkcsoft
Copy link
Member

bkcsoft commented Nov 4, 2016

Maybe add a pre-compile-tag as well while we're at it, which pulls in templates/, scripts/, public/ for a truly single-binary release 😉

@tboerger tboerger mentioned this issue Nov 4, 2016
Closed
2 tasks
@strk
Copy link
Member

strk commented Nov 5, 2016

My PR #78 is solely about the optionality of embedding

@strk strk mentioned this issue Nov 5, 2016
Closed
@strk strk mentioned this issue Nov 15, 2016
Closed
@tboerger tboerger added pr/wip This PR is not ready for review and removed in progress pr/wip This PR is not ready for review labels Nov 24, 2016
@tboerger
Copy link
Member Author

Solved via #354

jonas-salomonsson added a commit to cynergit/cynergit that referenced this issue Aug 15, 2017
@jonas-salomonsson
fixes go-gitea#30 fixes go-gitea#31 This changes the name of the sess…
a750cbe 
…ion cookie i_like_gitea too i_like_cynergit and also updates the cookie asked for.
lunny referenced this issue in lunny/gitea Feb 7, 2019
@Bwko @lunny
Update contributing & maintainers file (#30)
5ca1943
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tboerger tboerger

Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
3 participants
@tboerger @strk @bkcsoft