Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS error on pull files page #29956

Closed
wxiaoguang opened this issue Mar 21, 2024 · 5 comments · Fixed by #29963
Closed

JS error on pull files page #29956

wxiaoguang opened this issue Mar 21, 2024 · 5 comments · Fixed by #29963
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Milestone
1.22.0

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 21, 2024 •
edited
Loading

It looks like a regression of a recent PR (maybe Remove jQuery .attr from the archive download and compare page branch selector (#29918) )

Haven't got time to test or fix it. https://try.gitea.io/wxiaoguang/test/pulls/34/files (anonymous access)

image

image
@wxiaoguang wxiaoguang added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Mar 21, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Mar 21, 2024
@wxiaoguang wxiaoguang mentioned this issue Mar 21, 2024
Closed
@yp05327
Copy link
Contributor

yp05327 commented Mar 21, 2024

ps: https://try.gitea.io/wxiaoguang/test/ is a private repo

@wxiaoguang
Copy link
Contributor Author

ps: https://try.gitea.io/wxiaoguang/test/ is a private repo

I was doing some tests ... now it's public again 🤣

@vinsonzou
Copy link

Only Chrome 123 or above is abnormal.

@lunny lunny mentioned this issue Mar 21, 2024
Closed
@wxiaoguang
Copy link
Contributor Author

Only Chrome 123 or above is abnormal.

No. It isn't related to your browser. It is related to whether you have signed in.

silverwind added a commit to silverwind/gitea that referenced this issue Mar 21, 2024
@silverwind
Fix JS error and improve error styles
e7af015 
Fixes: go-gitea#29956
@silverwind silverwind mentioned this issue Mar 21, 2024
Merged
@silverwind
Copy link
Member

#29963

silverwind added a commit that referenced this issue Mar 21, 2024
@silverwind
Fix JS error and improve error message styles (#29963)
1a4f693 
Fixes: #29956. This error
exposed a existing bug in the code, it was just never noticed because
the jQuery expression evaluated without error before while the new one
doesn't.

Also improves error message styles:

Before:
<img width="1338" alt="Screenshot 2024-03-21 at 09 16 07"
src="https://github.com/go-gitea/gitea/assets/115237/1cc1ef89-ad94-491e-bbca-75387f7547a0">

After:
<img width="1335" alt="Screenshot 2024-03-21 at 09 15 44"
src="https://github.com/go-gitea/gitea/assets/115237/312efc79-5353-4e2a-a703-1bccd3c01736">
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 26, 2024
@silverwind @earl-warren
Fix JS error and improve error message styles (#29963)
faed933 
Fixes: go-gitea/gitea#29956. This error
exposed a existing bug in the code, it was just never noticed because
the jQuery expression evaluated without error before while the new one
doesn't.

Also improves error message styles:

Before:
<img width="1338" alt="Screenshot 2024-03-21 at 09 16 07"
src="https://github.com/go-gitea/gitea/assets/115237/1cc1ef89-ad94-491e-bbca-75387f7547a0">

After:
<img width="1335" alt="Screenshot 2024-03-21 at 09 15 44"
src="https://github.com/go-gitea/gitea/assets/115237/312efc79-5353-4e2a-a703-1bccd3c01736">

(cherry picked from commit 1a4f693f9f9723c181b747cb6d658aa37118005a)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Fix JS error and improve error message styles silverwind/gitea
4 participants
@silverwind @wxiaoguang @vinsonzou @yp05327