Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to Disable PGP/GPG Keys #29454

Closed
inferenceus opened this issue Feb 27, 2024 · 5 comments · Fixed by #29486
Closed

Ability to Disable PGP/GPG Keys #29454

inferenceus opened this issue Feb 27, 2024 · 5 comments · Fixed by #29486
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@inferenceus
Copy link

inferenceus commented Feb 27, 2024 •
edited
Loading

Feature Description

I have migrated from PGP keys to SSH keys and now enforce that only SSH keys are used on my server. I saw pull request #29447 is related to disabling SSH keys (the opposite of what I'm asking for here), and issue #20549 includes GPG keys but no SSH keys.

Is it possible to do the same as what's happening in PR #29447 for PGP/GPG keys?

Screenshots

No response
@inferenceus inferenceus added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 27, 2024
@delvh
Copy link
Member

delvh commented Feb 27, 2024

Probably.
TBH, I half expected that exact request to pop up when reviewing the PR 😆

@inferenceus
Copy link
Author

inferenceus commented Feb 27, 2024 •
edited
Loading

Probably. TBH, I half expected that exact request to pop up when reviewing the PR 😆

PGP gets a lot of love despite its shortcomings (that's off-topic and an entirely different issue), but SSH seems to be scarcely-used or cared about. It would indeed be nice if this was implemented so I can just disable legacy PGP keys.

I already made an attempt at removing PGP from the UI at least, but I wasn't familiar enough with the Gitea codebase and it was too high-risk, so I just dropped it and hoped it would be possible. Now, here I am after seeing that the same thing is wanted, but for SSH keys (unfortunately, the opposite of what I want)...

@lunny lunny mentioned this issue Feb 29, 2024
Merged
@inferenceus
Copy link
Author

You guys are working on this?

Legendary.

@lunny
Copy link
Member

lunny commented Mar 2, 2024

See #29486

lafriks pushed a commit that referenced this issue Mar 2, 2024
@lunny
Allow options to disable user gpg keys configuration from the interfa…
9de5e39 
…ce on app.ini (#29486)

Follow #29447
Fix #29454 
Extract from #20549
@inferenceus
Copy link
Author

@lunny

See #29486

You guys knocked it out of the park with this one.

Everyone is always "PGP this" and "GPG that", never "based SSH".

You are the first project I'm aware of which allows doing this. You have my thanks; much appreciated.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow options to disable user gpg keys configuration from the interface on app.ini lunny/gitea
3 participants
@lunny @delvh @inferenceus