-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Summary] Translation system overhaul #27700
Comments
Share some of my thoughts. Many translations in non-English locale are out-dated or event incorrect, because they didn't get updates when the English messages change. To make the translations clear, the first step is to |
We need to invalidate all affected tokens in all languages when english changes, it's the only sane config. It's doubly problematic if the |
Moved this out of 1.22 because a summary issue may cross multiple milestones. |
I think a good first step is when someone with access to crowdin admin panel would take a look at integrating https://github.com/crowdin/github-action, replacing the current ini workflow. Maybe a small script could be written that outputs the ini format to ease the transition. It would enable contributors to configure crowdin in-repo and likely gain a deeper understanding of the process in turn. @go-gitea/technical-oversight-committee can anyone with crowdin admin get this started? |
After fighting with the mess in our current translation files again and again, I think these are the steps we need to do:
We could also do 3. independently, but I don't have an overview of how the files are parsed currently |
One step I would like to do is to flatten the ini to make the keys greppable, e.g. turning [foo]
bar.baz = qux into foo.bar.baz = qux This can be easily done with a script and should be compatible with all the code. Question is just whether it might break anything regarding the crowdin sync. |
Alright, I have some spare time for a moment, so let's finally go forward with this. I propose the following steps:
as proposed by @wxiaoguang
as proposed above by @silverwind
Of course all these changes would be made with high caution and I plan to always double-check that we don't break Crowdin. @go-gitea/technical-oversight-committee please review the plan and tell me if I can go forward with it |
|
@lafriks Are you sure? Their docs sounds like they also have an approval system... |
Yes but translations are pushed back to source code even before approval It's been long open issue WeblateOrg/weblate#3745 |
Unfortunately after a lot of research I had to find out that 1. is not possible to do automatically as Crowdin does not support deleting all translation strings missing in an uploaded file. I started unapproving the outdated strings manually on Crowdin, but it will take a while... |
I now finished manually cleaning out translation strings which are newer than the source string, Should be done with next Crowdin pull :) |
Cleanup translations
General overhaul
Docs translation
The text was updated successfully, but these errors were encountered: