-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make /users/{username}/keys
endpoint more open
#27642
Labels
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
Comments
wiktor-k
added
the
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
label
Oct 16, 2023
Merged
lunny
pushed a commit
that referenced
this issue
Dec 25, 2023
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this issue
Dec 25, 2023
The CORS code has been unmaintained for long time, and the behavior is not correct. This PR tries to improve it. The key point is written as comment in code. And add more tests. Fix go-gitea#28515 Fix go-gitea#27642 Fix go-gitea#17098 # Conflicts: # tests/integration/cors_test.go
katsusan
pushed a commit
to katsusan/gitea
that referenced
this issue
Dec 26, 2023
The CORS code has been unmaintained for long time, and the behavior is not correct. This PR tries to improve it. The key point is written as comment in code. And add more tests. Fix go-gitea#28515 Fix go-gitea#27642 Fix go-gitea#17098
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this issue
Jan 17, 2024
The CORS code has been unmaintained for long time, and the behavior is not correct. This PR tries to improve it. The key point is written as comment in code. And add more tests. Fix go-gitea#28515 Fix go-gitea#27642 Fix go-gitea#17098
silverwind
pushed a commit
to silverwind/gitea
that referenced
this issue
Feb 20, 2024
The CORS code has been unmaintained for long time, and the behavior is not correct. This PR tries to improve it. The key point is written as comment in code. And add more tests. Fix go-gitea#28515 Fix go-gitea#27642 Fix go-gitea#17098
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Feature Description
Hi,
I've noticed that compared to Gitea's
/users/{username}/keys
endpoint GitHub's SSH keys endpoint is both 1) available to unauthenticated users 2) hasaccess-control-allow-origin: *
header (so it can be queried by web browser).Github:
Trying the same on Gitea:
Yields:
I wonder if it's possible to relax this. The keys are already publicly available in SSH format via https://try.gitea.io/wiktor.keys (but sadly that one doesn't have CORS).
My use-case is building a Keyoxide website that verifies identities but using SSH keys instead of OpenPGP. (If the keys are CORS-OK then the validation can be done purely in user's browser).
Thanks for your time! 👋
(If this sounds like a good addition I'm happy to submit a PR)
Screenshots
No response
The text was updated successfully, but these errors were encountered: