Render failed, failed to render template: user/profile

[HeikoDressler]

Description

on click to my Profile i got the following error:

Ein Fehler ist aufgetreten:

Render failed, failed to render template: user/profile, error: template error: builtin(bindata):shared/user/profile_big_avatar:86:87 : executing "shared/user/profile_big_avatar" at <.HasMemberWithUserID>: wrong number of args for HasMemberWithUserID: want 1 got 2

				{{if (or .Visibility.IsPublic (and ($.SignedUser) (or .Visibility.IsLimited (and (.HasMemberWithUserID ctx $.SignedUserID) .Visibility.IsPrivate) ($.IsAdmin))))}}
				                                                                                  ^

---

Gitea Version

1.21.0+rc0-69-g44aca6a65

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

2.37.1, Wire Protocol Version 2 Enabled

Operating System

Windows Server 2022 Standard

How are you running Gitea?

self hosting

Database

MSSQL

[silverwind]

#27417 is related, but maybe the fix there was wrong? @delvh

[silverwind]

The function takes 1 argument on 1.21 branch but two on 1.22, so the backport was incorrect:

gitea/models/organization/org.go

Line 150 in 44aca6a

func (org *Organization) HasMemberWithUserID(userID int64) bool {

gitea/models/organization/org.go

Line 150 in 023e937

func (org *Organization) HasMemberWithUserID(ctx context.Context, userID int64) bool {

[delvh]

Erm… Could it be that we didn't backport the refactoring PR before it and thus the backport was unnecessary?

[silverwind]

Yes, likely missed one backport with the function refactoring.

[delvh]

Hmm… Does reverting work for someone else on #27426? I only get a 500 on that page…