Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EasyMDE toolbar is broken #24486

Closed
wxiaoguang opened this issue May 2, 2023 · 5 comments · Fixed by #24489
Closed

EasyMDE toolbar is broken #24486

wxiaoguang opened this issue May 2, 2023 · 5 comments · Fixed by #24489
Assignees
@silverwind
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Milestone
1.20.0

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 2, 2023 •
edited
Loading

Related to #24471

I think we should keep EasyMDE, or at least find an alternative. Because when writing Wiki page, it is useful.

image
@wxiaoguang wxiaoguang mentioned this issue May 2, 2023
Merged
@silverwind
Copy link
Member

silverwind commented May 2, 2023 •
edited
Loading

I thought #24448 had replaced all these toolbar icons, but apparently only some. I guess we should restore with octicons.

@yardenshoham
Copy link
Member

#24448 removed direct references, not indirect ones. This probably broke after #24471

@yardenshoham
Copy link
Member

Shouldn't easymde ship its own font-awesome? Do we override its internal classes?

@wxiaoguang
Copy link
Contributor Author

We can manually construct every toolbar button, to use other icon sets.

@silverwind
Copy link
Member

silverwind commented May 2, 2023 •
edited
Loading

Yes, my oversight there. If the restoration is too much work, we could drop EasyMDE as well.

Shouldn't easymde ship its own font-awesome? Do we override its internal classes?

No, it apparently has an option autoDownloadFontAwesome which downloads it from CDN, but of course we needed to disable that as we don't want such downloads to happen.

@silverwind silverwind added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label May 2, 2023
@silverwind silverwind added this to the 1.20.0 milestone May 2, 2023
@silverwind silverwind self-assigned this May 2, 2023
@silverwind silverwind mentioned this issue May 2, 2023
Merged
silverwind added a commit that referenced this issue May 3, 2023
@silverwind @wxiaoguang
Fix EasyMDE toolbar (#24489)
a9ed87c 
Fixes #24486

The "clean block" button is gone because I could not find a matching
octicon. Order of buttons is roughly equal to textarea.

<img width="824" alt="Screenshot 2023-05-02 at 21 10 00"
src="https://user-images.githubusercontent.com/115237/235762593-ceccb260-e665-4932-ac8a-ef6fe8406a3c.png">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@silverwind silverwind

Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Fix EasyMDE toolbar silverwind/gitea
3 participants
@silverwind @wxiaoguang @yardenshoham