Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InsecureSkipVerify to Minio Client for Storage #23128

Closed
EStork09 opened this issue Feb 24, 2023 · 0 comments · Fixed by #23166
Closed

Add InsecureSkipVerify to Minio Client for Storage #23128

EStork09 opened this issue Feb 24, 2023 · 0 comments · Fixed by #23166
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@EStork09
Copy link

Feature Description

I think it would be great if InsecureSkipVerify could be an option added to the minio client. When doing internal communication to our minio server inside kubernetes, we cannot create a trusted certificate for something based upon *.cluster.local without great levels of effort.

minio/minio-go#1019
I can look to try to add this as a PR later if I get some free cycles

Screenshots

No response
@EStork09 EStork09 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Feb 24, 2023
@yardenshoham yardenshoham added type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 26, 2023
@yardenshoham yardenshoham mentioned this issue Feb 26, 2023
Merged
zeripath pushed a commit that referenced this issue Feb 27, 2023
@yardenshoham
Add InsecureSkipVerify to Minio Client for Storage (#23166)
0e7bec1 
Allows using Minio with untrusted certificates

Closes #23128

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
@yardenshoham yardenshoham mentioned this issue Feb 27, 2023
Merged
yardenshoham added a commit to yardenshoham/gitea that referenced this issue Feb 27, 2023
@yardenshoham
Add InsecureSkipVerify to Minio Client for Storage (go-gitea#23166)
cf1563d 
Allows using Minio with untrusted certificates

Closes go-gitea#23128

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
lafriks pushed a commit that referenced this issue Feb 27, 2023
@yardenshoham @techknowlogick
Add InsecureSkipVerify to Minio Client for Storage (#23166) (#23177)
111c509 
Backport #23166

Allows using Minio with untrusted certificates

Closes #23128

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add InsecureSkipVerify to Minio Client for Storage yardenshoham/gitea
2 participants
@yardenshoham @EStork09