-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Use tailwind style CSS class names for legacy helpers #23011
Comments
Would you encourage the usage of tailwind generally? As opposed to styling via css, in vuejs? |
I am not sure, maybe it's too early to introduce whole tailwind. IMO, at the moment, these |
Maybe in the near future, the rule is as simple as:
So Gitea could only have some very widely used tailwind-style CSS helpers, avoid filling every |
I find introducing parts of tailwind more confusing than just sticking to project owned helper classes. Generally I would either say remove helper classes over time and only roll with css in vuejs OR just use tailwind everywhere. |
I see your point. Actually, the tailwind-style already happened, there are already many. And I assume that maybe nobody has the confidence to introduce the whole tailwind at the moment, so maybe in the near future it's good to keep it as it was, only rename some legacy unclear helpers like gitea/web_src/less/helpers.less Line 21 in c8c2a31
|
There are still many other problems in Gitea's frontend framework. I don't see a progress for this proposal, so close it, until there is a clear picture. |
Feature Description
Before, the helper classes are called
df
,ac
,sb
, which are very difficult to understand.Now, Gitea has its own prefix
gt-
, so it's time to improve the legacy CSS class names. It would be very easy to do a search & replace since these names all have prefixes.Reference: https://tailwind.build/classes
Example:
Screenshots
No response
The text was updated successfully, but these errors were encountered: