-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for mobile view messed up non-mobile view #20245
fix for mobile view messed up non-mobile view #20245
Comments
Can in try.gitea.io duplication it? |
just tried, I cannot reproduce there. are you sure it isn't returning a cached version of the toolbar? |
I'm not able to reproduce this on firefox or on chrome on try or on a dev main build. |
must be an issue with my tmpl (I have integrated latest changes but perhaps left something there when I shouldn't have), let me check. |
I should note I have been able to reproduce it - but it's more subtle on my default font than it is for @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf The problem appears to relate to the use of The #20236 switched to use |
for anyone stumbling upon this later, most of the discussion can be found via following the "review" link in the OP. |
the fix of #20236 does indeed hide the "non-mobile" bell in the mobile view (as it's supposed to), however, the bell in my "non-mobile" toolbar got a little messed up as a result.
you can see in the picture that it's positioned a little above the toolbar centerline, compared to surrounding elements.
pic:
Originally posted by @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf in #20236 (review)
The text was updated successfully, but these errors were encountered: