Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for mobile view messed up non-mobile view #20245

Closed
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf opened this issue Jul 5, 2022 · 6 comments · Fixed by #20251
Closed

fix for mobile view messed up non-mobile view #20245

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf opened this issue Jul 5, 2022 · 6 comments · Fixed by #20251

Comments

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

the fix of #20236 does indeed hide the "non-mobile" bell in the mobile view (as it's supposed to), however, the bell in my "non-mobile" toolbar got a little messed up as a result.

you can see in the picture that it's positioned a little above the toolbar centerline, compared to surrounding elements.

pic:
image

Originally posted by @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf in #20236 (review)

@tyroneyeh
Copy link
Contributor

Can in try.gitea.io duplication it?

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor Author

Can in try.gitea.io duplication it?

just tried, I cannot reproduce there. are you sure it isn't returning a cached version of the toolbar?

@zeripath
Copy link
Contributor

zeripath commented Jul 5, 2022

I'm not able to reproduce this on firefox or on chrome on try or on a dev main build.

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor Author

I'm not able to reproduce this on firefox or on chrome on try or on a dev main build.

must be an issue with my tmpl (I have integrated latest changes but perhaps left something there when I shouldn't have), let me check.

@zeripath
Copy link
Contributor

zeripath commented Jul 5, 2022

I'm not able to reproduce this on firefox or on chrome on try or on a dev main build.

I should note I have been able to reproduce it - but it's more subtle on my default font than it is for @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf


The problem appears to relate to the use of m-4 text black tooltip no-mobile as the class versus item tooltip no-mobile.

m-4:
Screenshot from 2022-07-05 12-59-13
Screenshot from 2022-07-05 12-59-49

item:
Screenshot from 2022-07-05 13-00-01
Screenshot from 2022-07-05 12-59-38

The m-4 isn't aligning things in the same way as item does therefore the bell is shifted up on the midline.

#20236 switched to use m-4 because a css selector on item sets a display: flex overriding that of the no-mobile because that class doesn't set !important.

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor Author

for anyone stumbling upon this later, most of the discussion can be found via following the "review" link in the OP.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants