Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protected Tags dont protect if delete happens via WebUI #19970

Closed
6543 opened this issue Jun 14, 2022 · 1 comment · Fixed by #19985
Closed

Protected Tags dont protect if delete happens via WebUI #19970

6543 opened this issue Jun 14, 2022 · 1 comment · Fixed by #19985
Labels
topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Milestone
1.17.0

Comments

@6543
Copy link
Member

6543 commented Jun 14, 2022 •
edited
Loading

Gitea Version

v1.16.x (codeberg.org); up to main (460c03c)

Reproduce

  1. create a tag
  2. protect this tag
  3. delete via webui

expect

A. no delete option for protected tags
B. an error if backend gets delete request
@6543 6543 added the type/bug label Jun 14, 2022
@6543 6543 added this to the 1.17.0 milestone Jun 14, 2022
@6543
Copy link
Member Author

6543 commented Jun 14, 2022

also if you like to create a tag witch is protected via UI you get an 500 page

a flash error would be a better UX

@6543 6543 added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Jun 15, 2022
a1012112796 added a commit to a1012112796/gitea that referenced this issue Jun 16, 2022
@a1012112796
fix permission check for delete tag
b36eb78 
fix go-gitea#19970

by the way, fix some error response about
protected tags.

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this issue Jun 16, 2022
Merged
6543 pushed a commit that referenced this issue Jun 16, 2022
@a1012112796
fix permission check for delete tag (#19985)
e3e06d1 
fix #19970

by the way, fix some error response about protected tags.

Signed-off-by: a1012112796 <1012112796@qq.com>
a1012112796 added a commit to a1012112796/gitea that referenced this issue Jun 17, 2022
@a1012112796
fix permission check for delete tag (go-gitea#19985)
b1262d0 
fix go-gitea#19970

by the way, fix some error response about protected tags.

Signed-off-by: a1012112796 <1012112796@qq.com>
zeripath pushed a commit that referenced this issue Jun 17, 2022
@a1012112796
fix permission check for delete tag (#19985) (#20001)
4b7f0c6 
fix #19970

by the way, fix some error response about protected tags.

Signed-off-by: a1012112796 <1012112796@qq.com>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 10, 2022
@a1012112796
fix permission check for delete tag (go-gitea#19985)
8d93e5d 
fix go-gitea#19970

by the way, fix some error response about protected tags.

Signed-off-by: a1012112796 <1012112796@qq.com>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 24, 2022
@a1012112796 @AbdulrhmnGhanem
fix permission check for delete tag (go-gitea#19985)
26a2f16 
fix go-gitea#19970

by the way, fix some error response about protected tags.

Signed-off-by: a1012112796 <1012112796@qq.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging a pull request may close this issue.

fix permission check for delete tag a1012112796/gitea
1 participant
@6543