Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown renderer with lua filter header broken #19061

Open
pfpulux opened this issue Mar 11, 2022 · 2 comments
Open

markdown renderer with lua filter header broken #19061

pfpulux opened this issue Mar 11, 2022 · 2 comments
Labels
outdated/theme/markdown type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there

Comments

@pfpulux
Copy link

pfpulux commented Mar 11, 2022

Gitea Version

1.16.3

Git Version

2.35

Operating System

voidlinux

How are you running Gitea?

distribution package run as runit service

Database

SQLite

Log Gist

No response

Description

After an update from 11 to 16 the markdown renderer don't render the whole file if it includes a lua-filter header.

example
markdown source

Screenshots

No response

@pfpulux pfpulux changed the title markdown renderer with lua filter header brken markdown renderer with lua filter header broken Mar 11, 2022
@lunny lunny added the type/bug label Mar 11, 2022
@noerw
Copy link
Member

noerw commented Mar 12, 2022

Can confirm, but note that the header is terminated by ..., is this really what you wanted?
I never heard of lua filter headers (do you have resources on that?), only yaml headers which are terminated by --- and are working correctly.
I assume Gitea tries to parse a yaml header, finds that it never terminates, and thus doesn't even start parsing or rendering markdown.

@noerw noerw added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail outdated/theme/markdown labels Mar 12, 2022
@pfpulux
Copy link
Author

pfpulux commented Mar 14, 2022

Hm, may not lua header, it is more or less yaml.

We use usage eisvogel.tex and the example from Usage shows this:

---
title: "The Document Title"
author: [Example Author, Another Author]
date: "2017-02-20"
keywords: [Markdown, Example]
...

Here is the actual document text...

Ah, may a bad example, which ... means there is more.

Nop also the basic-example use this syntax, see also the pandoc docs

@wxiaoguang wxiaoguang added type/upstream This is an issue in one of Gitea's dependencies and should be reported there and removed dependencies issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated/theme/markdown type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Development

No branches or pull requests

4 participants