Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line context menu and highlight is not always working #18721

Closed
jpraet opened this issue Feb 11, 2022 · 0 comments · Fixed by #18729
Closed

Line context menu and highlight is not always working #18721

jpraet opened this issue Feb 11, 2022 · 0 comments · Fixed by #18729
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.16.2

Comments

@jpraet
Copy link
Member

jpraet commented Feb 11, 2022

Gitea Version

1.16.1

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

Since upgrading to Gitea 1.16.1, clicking on a line of a file (in the source browsing view) no longer highlights it.
I notice in #17145 it is supposed to display a context menu, but I don't see it.

Strangely enough, when trying to reproduce on try.gitea.io, I see that it's working for some files, but not for others?

Working here:

Not working here:

Screenshots

Not OK:

image

OK:

image
@silverwind silverwind added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 11, 2022
@jpraet jpraet mentioned this issue Feb 11, 2022
Merged
@lunny lunny added this to the 1.16.2 milestone Feb 12, 2022
wxiaoguang added a commit to jpraet/gitea that referenced this issue Feb 12, 2022
@wxiaoguang
Merge branch 'main' into go-gitea#18721-fix-line-highlight
ebb8f20
@zeripath zeripath mentioned this issue Feb 12, 2022
Merged
zeripath pushed a commit that referenced this issue Feb 12, 2022
@jpraet
Fix source code line highlighting (#18729) (#18740)
edf85b8 
Backport #18729

When the issues repo unit is disabled, or an external issue tracker is used, there is no "a.ref-in-new-issue".

Fixes #18721
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.16.2
Development

Successfully merging a pull request may close this issue.

Fix source code line selection on external issue tracker jpraet/gitea
3 participants
@lunny @silverwind @jpraet