Use go:embed for embedding files instead of vfsgen

[techknowlogick]

Feature Description

Now that we have a minimum of go1.16 set, we can use go's embed functionality to embed templates/web assets (css/js), and translations.

Screenshots

No response

[6543]

example:
https://github.com/woodpecker-ci/woodpecker/blob/ed6d3f3cea2c9ceab5dbcd22bcc25b48e7523ab2/web/web.go#L10-L11

[lafriks]

only we will have to do some restucture of code as you can not embed files that are not in the same directory or in child directory where golang code is where you are embedding it.

[lunny]

go:embed don't support ../ on path, the directory structure have to be changed.

[silverwind]

Maybe symlink before build?

[jolheiser]

We can add a small go file in those locations to grab the assets.

[silverwind]

Another thing to consider is that vfsgen provides the gzip versions of assets which we directly serve from the http server if the client indicates gzip support. I think it's crucial for performance to retain the option to serve pre-compiled gzip assets.

Edit:

See https://github.com/vearutop/statigz for one approach to solve it. I also maintain a JS module to generate .gz and .br files at https://github.com/silverwind/precompress.

[rahulsurwade08]

Hey @techknowlogick , I would love to contribute to this issue under Hacktoberfest. How can I get started?

[6543]

the main concern is that if we ose std embeded the compressed files would be decompressed and compressed on each request that indicated gzip support ...

... @techknowlogick should we close this issue?

[wxiaoguang]

There could be a comment in code for why the vfsgen is chosen, to help future developers know the background. Otherwise months later the knowledge may be lost.