Skip to content

Primary email cannot be activated when ‘RegisterEmailConfirm’ is enabled #16370

Closed
@Meano

Description

@Meano
  • Gitea version (or commit ref): 1.15.0+dev-549-gbc6f060b8

  • Git version: 2.30.2

  • Operating system:

    Ubuntu 21.04 & Windows 10
    Both the official version and the version compiled by myself have been tested.
    I am running gitea from systemd(247.3-3ubuntu3.1) or WinSW(3.0.0).

  • Database (use [x]):

    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:

    • Yes (/user/settings/account /admin/emails)
    • No
  • Log gist:

It fired an error when a new user who signed up without primary mail activated click the Send Activation button.

Send activation: email not set for activation

Description

  1. When RegisterEmailConfirm is enabled, the primary email should be activated together with the user account. Otherwise, the primary email can not be activated for the Send Activation not work, and the admin can not activate the user email either.
  2. There is some invalid params in email template since Localize Email Templates #16200. Like %!(EXTRA string=xxx, string=Gitea: Git with a cup of tea)
  3. I guess the i18n: mail.activate_account.test_x might be a typo, maybe mail.activate_account.text_x?

I have fixed the errors above. Could I create a PR?
main...Meano:develop

Screenshots

SendActionNot Working
AdminActivateNotWorking

InvalidParams

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions