-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make go packages from subdirectories on gitea instances installable with "go get" #1485
Comments
Since this affects me more than I thought, I've decided to start looking into it. I've found that the header file in the base template folder already contains a meta tag for that, but that doesn't work, because somehow {{.GoGetImport}} doesn't start with the domain, but with localhost instead. |
@jcgruenhage any news? |
I test |
I've changed the title. If the root directory is the go project you want to get, there is no problem, but if you want to get something in a subdirectory, that does not work, since the 404 page does not contain the appropriate meta tags. |
Works:
Doesn't work:
Workaround:Clone the repo into |
#1518 should fix |
I am not sure why, but it seems to work.. I didn't think that that HTTP func was actually called when serving a 404.. |
Currently, you can't fetch go projects from gitea, without the .git extension. This causes the binaries to have this ugly .git extension too and prevents people from fetching projects from subdirectories.
Documentation of meta-tags: https://golang.org/cmd/go/#hdr-Remote_import_paths
The PR and commit that fixed this in gitlab: gitlabhq/gitlabhq#7693 gitlabhq/gitlabhq@e23d6ad
The text was updated successfully, but these errors were encountered: