issue_label and issue_milestone webhooks not triggered on new issue

[jpraet]

• Gitea version (or commit ref): 1.13.1
• Can you reproduce the bug at https://try.gitea.io:
  • Yes

Description

The issue_label, issue_milestone, pull_request_label and pull_request_milestone webhooks are not triggered when you immediately provide the label or milestone when creating the new issue/pr. When adding the label or milestone AFTER the issue/pr has already been created it works fine.

This is not consistent with the issue_assign/pull_request_assign webhooks: these also get triggered if you provide the assignee immediately when creating the new issue/pr.

Screenshots

The webhook:

Only receives the notification for the issue_assign.

[lunny]

Should we remove all extra events when create an issue/pull request or add them all?

[jpraet]

Emitting the labeled/milestoned/assigned events regardless of whether they were added at creation time or afterwards seems most intuitive to me, from the point of view of configuring and implementing a webhook.