Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon with badges - notifications #1415

Open
lcges opened this issue Mar 30, 2017 · 4 comments
Open

Favicon with badges - notifications #1415

lcges opened this issue Mar 30, 2017 · 4 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@lcges
Copy link

lcges commented Mar 30, 2017

My suggestion is to exchange early notifications with a new model.
OLD: Favicon + (notification digit) + Title
NEW: Favicon with badges + Title

This way we will save some space.

Suggested library: http://lab.ejci.net/favico.js/

2017-03-30t14 45 40 02 00-123x91
gitea_not

@andreynering andreynering added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Mar 30, 2017
@lunny lunny added this to the 1.x.x milestone Mar 31, 2017
@stale
Copy link

stale bot commented Feb 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 16, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 28, 2019
@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Jun 5, 2022

Which file would need to change here?

I can't tell from looking at

<title>{{if .Title}}{{.Title | RenderEmojiPlain}} - {{end}} {{if .Repository.Name}}{{.Repository.Name}} - {{end}}{{AppName}}</title>

Since we use SVG for the favicon, that could be turned inline (and become dynamic this way).

@lunny
Copy link
Member

lunny commented Jun 6, 2022

Should we create a dynamic graph for that?

@Ryuno-Ki
Copy link
Contributor

I don't know Golang enough. Are there libraries to aid with it? Otherwise it will be a bit hairy to write (I could take a stab, but not for the upcoming release).

https://css-tricks.com/svg-favicons-and-all-the-fun-things-we-can-do-with-them/ gives you some ideas on what you could do with a SVG favicon.

I mean, the web being the place it is yield to http://www.p01.org/defender_of_the_favicon/ and friends 😆

@lunny lunny removed this from the 1.x.x milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

4 participants