Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab migration: fals token error is not reported #12779

Closed
6543 opened this issue Sep 9, 2020 · 5 comments · Fixed by #12793
Closed

gitlab migration: fals token error is not reported #12779

6543 opened this issue Sep 9, 2020 · 5 comments · Fixed by #12793
Labels
Milestone

Comments

@6543
Copy link
Member

6543 commented Sep 9, 2020

gitea v: 1.13.0+dev-583-g090024db3

Migrate repository from https://gitlab.com/gitea/test_repo failed: error: GitlabDownloader is nil

@6543 6543 added this to the 1.13.0 milestone Sep 9, 2020
@6543 6543 added the type/bug label Sep 9, 2020
@jolheiser
Copy link
Member

Doing a little testing on try, it seems to work with a token. But migrating fails if using GitLab without a token.

@jolheiser
Copy link
Member

I think what needs to happen here is that if no auth is passed, we should use the plain git downloader because the GitLab client expects to log into GL.

@6543 6543 changed the title gitlab migration do not work gitlab migration: fals token error is not reported Sep 9, 2020
@6543
Copy link
Member Author

6543 commented Sep 9, 2020

@jolheiser the first api call retuned this: {message: 401 Unauthorized} - if token is wrong/outdated ->
currently it only will thell Downloader == nil but not the reason

@jolheiser
Copy link
Member

Gotcha. Alright, so then it needs a small refactor as well.

@6543
Copy link
Member Author

6543 commented Sep 9, 2020

also notized we need a collor-code noramlizer: ( gitlab allow code #fde -> #ffddee )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants