Don't replace underscores in auto-generated IDs in goldmark (#12805)

zeripath · web-flow · commit f91bb745d6f6 · 2020-09-12T12:00:48.000-04:00
Fix #12196 Signed-off-by: Andrew Thornton <art27@cantab.net>
diff --git a/modules/markup/common/footnote.go b/modules/markup/common/footnote.go
@@ -34,7 +34,7 @@ func CleanValue(value []byte) []byte {
 	needsDash := false
 	for _, r := range rs {
 		switch {
-		case unicode.IsLetter(r) || unicode.IsNumber(r):
+		case unicode.IsLetter(r) || unicode.IsNumber(r) || r == '_':
 			if needsDash && len(result) > 0 {
 				result = append(result, '-')
 			}

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ func CleanValue(value []byte) []byte {`
`34`	`34`	`needsDash := false`
`35`	`35`	`for _, r := range rs {`
`36`	`36`	`switch {`
`37`		`- case unicode.IsLetter(r) \|\| unicode.IsNumber(r):`
	`37`	`+ case unicode.IsLetter(r) \|\| unicode.IsNumber(r) \|\| r == '_':`
`38`	`38`	`if needsDash && len(result) > 0 {`
`39`	`39`	`result = append(result, '-')`
`40`	`40`	`}`