simplify by removing unnneccessary if/else

adelowo · adelowo · commit ddced419d8c6 · 2018-10-06T11:38:24.000+01:00
diff --git a/cmd/admin.go b/cmd/admin.go
@@ -289,13 +289,11 @@ func runCreateUser(c *cli.Context) error {
 		return err
 	}
 
-	var changePassword bool
+	// always default to true
+	var changePassword = true
 
 	if c.IsSet("must-change-password") {
 		changePassword = c.Bool("must-change-password")
-	} else {
-		// always default to true
-		changePassword = true
 	}
 
 	if err := models.CreateUser(&models.User{

Original file line number	Diff line number	Diff line change
`@@ -289,13 +289,11 @@ func runCreateUser(c *cli.Context) error {`
`289`	`289`	`return err`
`290`	`290`	`}`
`291`	`291`
`292`		`- var changePassword bool`
	`292`	`+ // always default to true`
	`293`	`+ var changePassword = true`
`293`	`294`
`294`	`295`	`if c.IsSet("must-change-password") {`
`295`	`296`	`changePassword = c.Bool("must-change-password")`
`296`		`- } else {`
`297`		`- // always default to true`
`298`		`- changePassword = true`
`299`	`297`	`}`
`300`	`298`
`301`	`299`	`if err := models.CreateUser(&models.User{`