Skip to content

Commit

Permalink
Add accessibility to the menu on the navbar (#23059) (#23095)
Browse files Browse the repository at this point in the history
Backport #23059

This PR is trying to add accessibility to the menu as mentioned in
#23053 so the menu can be accessed using keyboard (A quick demo is added
below), with a reference to
[PR2612](#22612). The goal is to
make the menu accessible merely using keyboard like shown below. And
this PR might need confirmation from developers using screen readers.
  • Loading branch information
HesterG authored Feb 23, 2023
1 parent aff432b commit ced94f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions templates/base/head_navbar.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
</span>
</a>
{{end}}
<div class="ui icon button mobile-only" id="navbar-expand-toggle">
<button class="ui icon button mobile-only" id="navbar-expand-toggle">
{{svg "octicon-three-bars"}}
</div>
</button>
</div>
</div>

Expand Down

0 comments on commit ced94f2

Please sign in to comment.