Refactor .length > 0 pattern

bytedream · silverwind · web-flow · commit c7a8412b3ede · 2024-03-25T19:56:14.000+01:00
Co-authored-by: silverwind &lt;me@silverwind.io&gt;
diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue
@@ -200,7 +200,7 @@ const sfc = {
       }
 
       // scrolls to the bottom if job is running and the bottom of the logs container is visible
-      if (!this.run.done && logLines.length > 0 && clientHeight >= logsContainerHeight) {
+      if (!this.run.done && logLines.length && clientHeight >= logsContainerHeight) {
         const newLogsContainerHeight = this.$refs.stepsContainer.getBoundingClientRect().bottom + window.scrollY;
         window.scrollTo({top: clientHeight + (newLogsContainerHeight - logsContainerHeight), behavior: 'smooth'});
       }

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ const sfc = {`
`200`	`200`	`}`
`201`	`201`
`202`	`202`	`// scrolls to the bottom if job is running and the bottom of the logs container is visible`
`203`		`- if (!this.run.done && logLines.length > 0 && clientHeight >= logsContainerHeight) {`
	`203`	`+ if (!this.run.done && logLines.length && clientHeight >= logsContainerHeight) {`
`204`	`204`	`const newLogsContainerHeight = this.$refs.stepsContainer.getBoundingClientRect().bottom + window.scrollY;`
`205`	`205`	`window.scrollTo({top: clientHeight + (newLogsContainerHeight - logsContainerHeight), behavior: 'smooth'});`
`206`	`206`	`}`