Refactor empty objectID detection

Author: AdamMajer

models/repo/repo.go

@@ -317,7 +317,7 @@ func (repo *Repository) HTMLURL() string {
 // CommitLink make link to by commit full ID
 // note: won't check whether it's an right id
 func (repo *Repository) CommitLink(commitID string) (result string) {
-	if commitID == "" || commitID == repo.ObjectFormat.Empty().String() {
+	if git.IsEmptyCommitID(commitID) {
 		result = ""
 	} else {
 		result = repo.Link() + "/commit/" + url.PathEscape(commitID)

modules/git/hash.go

@@ -181,6 +181,19 @@ func IDFromString(hexHash string) (ObjectID, error) {
 	return nil, fmt.Errorf("invalid hash hex string: '%s' len: %d", hexHash, len(hexHash))
 }
 
+func IsEmptyCommitID(commitID string) bool {
+	if commitID == "" {
+		return true
+	}
+
+	id, err := IDFromString(commitID)
+	if err != nil {
+		return false
+	}
+
+	return id.IsZero()
+}
+
 // HashInterface is a struct that will generate a Hash
 type HasherInterface interface {
 	hash.Hash

routers/private/hook_post_receive.go

@@ -158,13 +158,8 @@ func HookPostReceive(ctx *gitea_context.PrivateContext) {
 			continue
 		}
 
-		commitID, err := git.IDFromString(newCommitID)
-		if err != nil {
-			commitID = &git.Sha1Hash{}
-		}
-
 		// If we've pushed a branch (and not deleted it)
-		if newCommitID != commitID.Type().Empty().String() && refFullName.IsBranch() {
+		if git.IsEmptyCommitID(newCommitID) && refFullName.IsBranch() {
 			// First ensure we have the repository loaded, we're allowed pulls requests and we can get the base repo
 			if repo == nil {
 				repo = loadRepository(ctx, ownerName, repoName)