Skip to content

Commit

Permalink
Change Close to either Close issue or Close pull request
Browse files Browse the repository at this point in the history
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
  • Loading branch information
yardenshoham committed Mar 15, 2023
1 parent 6aef9e0 commit a7212e7
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
3 changes: 2 additions & 1 deletion options/locale/locale_en-US.ini
Original file line number Diff line number Diff line change
Expand Up @@ -1369,7 +1369,7 @@ issues.context.reference_issue = Reference in New Issue
issues.context.edit = Edit
issues.context.delete = Delete
issues.no_content = There is no content yet.
issues.close_issue = Close
issues.close_issue = Close issue
issues.pull_merged_at = `merged commit <a class="ui sha" href="%[1]s"><code>%[2]s</code></a> into <b>%[3]s</b> %[4]s`
issues.manually_pull_merged_at = `merged commit <a class="ui sha" href="%[1]s"><code>%[2]s</code></a> into <b>%[3]s</b> manually %[4]s`
issues.close_comment_issue = Comment and Close
Expand Down Expand Up @@ -1654,6 +1654,7 @@ pulls.update_branch_rebase = Update branch by rebase
pulls.update_branch_success = Branch update was successful
pulls.update_not_allowed = You are not allowed to update branch
pulls.outdated_with_base_branch = This branch is out-of-date with the base branch
pulls.close = Close pull request
pulls.closed_at = `closed this pull request <a id="%[1]s" href="#%[1]s">%[2]s</a>`
pulls.reopened_at = `reopened this pull request <a id="%[1]s" href="#%[1]s">%[2]s</a>`
pulls.merge_instruction_hint = `You can also view <a class="show-instruction">command line instructions</a>.`
Expand Down
12 changes: 12 additions & 0 deletions templates/repo/issue/view_content.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,15 @@
{{.locale.Tr "repo.issues.reopen_issue"}}
</button>
{{else}}
{{if .Issue.IsPull}}
<button id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.pulls.close"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
{{.locale.Tr "repo.pulls.close"}}
</button>
{{else}}
<button id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.issues.close_issue"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
{{.locale.Tr "repo.issues.close_issue"}}
</button>
{{end}}
{{end}}
{{end}}
<button class="ui green button loading-button" tabindex="5">
Expand Down Expand Up @@ -167,9 +173,15 @@
{{.locale.Tr "repo.issues.reopen_issue"}}
</button>
{{else}}
{{if .Issue.IsPull}}
<button id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.pulls.close"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
{{.locale.Tr "repo.pulls.close"}}
</button>
{{else}}
<button id="status-button" class="ui red basic button" tabindex="6" data-status="{{.locale.Tr "repo.issues.close_issue"}}" data-status-and-comment="{{.locale.Tr "repo.issues.close_comment_issue"}}" data-status-val="close">
{{.locale.Tr "repo.issues.close_issue"}}
</button>
{{end}}
{{end}}
{{end}}
<button class="ui green button loading-button" tabindex="5">
Expand Down

0 comments on commit a7212e7

Please sign in to comment.