Skip to content

Commit

Permalink
Added missing error checks in tests (#7554)
Browse files Browse the repository at this point in the history
Whenever we assign a value to err, check for it being nil.
  • Loading branch information
muesli authored and zeripath committed Jul 23, 2019
1 parent 54d96c7 commit 5e4e7d3
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions models/release_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ func TestRelease_MirrorDelete(t *testing.T) {
assert.True(t, ok)

count, err := GetReleaseCountByRepoID(mirror.ID, findOptions)
assert.NoError(t, err)
assert.EqualValues(t, initCount+1, count)

release, err := GetRelease(repo.ID, "v0.2")
Expand All @@ -149,5 +150,6 @@ func TestRelease_MirrorDelete(t *testing.T) {
assert.True(t, ok)

count, err = GetReleaseCountByRepoID(mirror.ID, findOptions)
assert.NoError(t, err)
assert.EqualValues(t, initCount, count)
}
1 change: 1 addition & 0 deletions models/repo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ func TestUpdateRepositoryVisibilityChanged(t *testing.T) {

// Get sample repo and change visibility
repo, err := GetRepositoryByID(9)
assert.NoError(t, err)
repo.IsPrivate = true

// Update it
Expand Down
5 changes: 4 additions & 1 deletion modules/git/repo_commit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ func TestRepository_GetCommitBranches(t *testing.T) {
func TestGetTagCommitWithSignature(t *testing.T) {
bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
bareRepo1, err := OpenRepository(bareRepo1Path)
commit, err := bareRepo1.GetCommit("3ad28a9149a2864384548f3d17ed7f38014c9e8a")
assert.NoError(t, err)

commit, err := bareRepo1.GetCommit("3ad28a9149a2864384548f3d17ed7f38014c9e8a")
assert.NoError(t, err)
assert.NotNil(t, commit)
assert.NotNil(t, commit.Signature)
Expand All @@ -52,6 +53,8 @@ func TestGetTagCommitWithSignature(t *testing.T) {
func TestGetCommitWithBadCommitID(t *testing.T) {
bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
bareRepo1, err := OpenRepository(bareRepo1Path)
assert.NoError(t, err)

commit, err := bareRepo1.GetCommit("bad_branch")
assert.Nil(t, commit)
assert.Error(t, err)
Expand Down
1 change: 1 addition & 0 deletions modules/git/repo_stats_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ func TestRepository_GetCodeActivityStats(t *testing.T) {
assert.NoError(t, err)

timeFrom, err := time.Parse(time.RFC3339, "2016-01-01T00:00:00+00:00")
assert.NoError(t, err)

code, err := bareRepo1.GetCodeActivityStats(timeFrom, "")
assert.NoError(t, err)
Expand Down

0 comments on commit 5e4e7d3

Please sign in to comment.